-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added denom-owners grpc_web api and cli query #2508
Conversation
WalkthroughThe updates involve integrating a new Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
x/ugov/keeper/keeper.go (2)
15-17
: Ensure that theBankKeeper
field is properly documented.Adding a comment explaining the purpose of the
BankKeeper
field in theBuilder
struct would improve code readability and maintainability.
45-47
: Ensure that theBankKeeper
field is properly documented.Adding a comment explaining the purpose of the
BankKeeper
field in theKeeper
struct would improve code readability and maintainability.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2508 +/- ##
===========================================
- Coverage 75.38% 62.99% -12.40%
===========================================
Files 100 271 +171
Lines 8025 15701 +7676
===========================================
+ Hits 6050 9891 +3841
- Misses 1589 5054 +3465
- Partials 386 756 +370
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
proto/umee/ugov/v1/query.proto (1)
40-44
: The new RPC methodDenomOwners
is a valuable addition for querying token ownership by denomination. Ensure that the implementation is optimized for performance and scalability.
This reverts commit 0e74c15.
Description
Summary by CodeRabbit