Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go-schnorrkel and keyring dependencies #2344

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

robert-zaremba
Copy link
Member

Description

Fix: remove replace which was outdated and add fix the keyring dependency.

@robert-zaremba robert-zaremba requested a review from a team as a code owner December 1, 2023 13:24
@robert-zaremba robert-zaremba added the skip-e2e-test Skip the e2e tests label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #2344 (d50bec1) into main (7f05ad4) will decrease coverage by 5.21%.
Report is 305 commits behind head on main.
The diff coverage is 66.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
- Coverage   75.38%   70.18%   -5.21%     
==========================================
  Files         100      170      +70     
  Lines        8025    12646    +4621     
==========================================
+ Hits         6050     8875    +2825     
- Misses       1589     3167    +1578     
- Partials      386      604     +218     
Files Coverage Δ
ante/ante.go 66.66% <100.00%> (+18.45%) ⬆️
ante/fee.go 80.00% <100.00%> (+1.64%) ⬆️
ante/spam_prevention.go 75.92% <ø> (ø)
app/inflation/inflation.go 100.00% <100.00%> (ø)
app/upgradev3/migrations.go 84.21% <ø> (+5.94%) ⬆️
util/coin/utoken.go 100.00% <100.00%> (ø)
util/ibc/ibc.go 58.82% <ø> (ø)
util/sdkutil/events.go 0.00% <ø> (ø)
util/store/store.go 52.06% <ø> (+10.65%) ⬆️
util/store/unmarshal.go 42.85% <ø> (ø)
... and 40 more

... and 103 files with indirect coverage changes

@robert-zaremba robert-zaremba added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 1507d63 Dec 1, 2023
32 of 38 checks passed
@robert-zaremba robert-zaremba deleted the robert/fix-deps branch December 1, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants