Skip to content

Commit

Permalink
address check
Browse files Browse the repository at this point in the history
  • Loading branch information
gsk967 committed Jun 6, 2024
1 parent 447c01f commit f8b24cc
Showing 1 changed file with 6 additions and 16 deletions.
22 changes: 6 additions & 16 deletions x/auction/keeper/rewards.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,8 @@ func (k Keeper) FinalizeRewardsAuction() error {

bid, _ := k.getRewardsBid(id)
if bid != nil && len(bid.Bidder) != 0 {
bidderAccAddr, err := sdk.AccAddressFromBech32(bid.Bidder)
if err != nil {
return err
}
err = k.sendCoins(k.accs.RewardsCollect, bidderAccAddr, a.Rewards)
bidderAccAddr := sdk.MustAccAddressFromBech32(bid.Bidder)
err := k.sendCoins(k.accs.RewardsCollect, bidderAccAddr, a.Rewards)

Check warning on line 31 in x/auction/keeper/rewards.go

View check run for this annotation

Codecov / codecov/patch

x/auction/keeper/rewards.go#L30-L31

Added lines #L30 - L31 were not covered by tests
if err != nil {
return fmt.Errorf("can't send coins to finalize the auction [%w]", err)
}
Expand Down Expand Up @@ -85,22 +82,15 @@ func (k Keeper) rewardsBid(msg *auction.MsgRewardsBid) error {
toAuction = msg.Amount.SubAmount(lastBid.Amount)
} else {
returned := coin.UmeeInt(lastBid.Amount)
bidderAccAddr, err := sdk.AccAddressFromBech32(lastBid.Bidder)
if err != nil {
return err
}
if err = k.sendFromModule(bidderAccAddr, returned); err != nil {
bidderAccAddr := sdk.MustAccAddressFromBech32(lastBid.Bidder)
if err := k.sendFromModule(bidderAccAddr, returned); err != nil {

Check warning on line 86 in x/auction/keeper/rewards.go

View check run for this annotation

Codecov / codecov/patch

x/auction/keeper/rewards.go#L85-L86

Added lines #L85 - L86 were not covered by tests
return err
}
}
}

sender, err := sdk.AccAddressFromBech32(msg.Sender)
if err != nil {
return err
}

if err = k.sendToModule(sender, toAuction); err != nil {
sender := sdk.MustAccAddressFromBech32(msg.Sender)
if err := k.sendToModule(sender, toAuction); err != nil {

Check warning on line 93 in x/auction/keeper/rewards.go

View check run for this annotation

Codecov / codecov/patch

x/auction/keeper/rewards.go#L92-L93

Added lines #L92 - L93 were not covered by tests
return err
}

Expand Down

0 comments on commit f8b24cc

Please sign in to comment.