feat: price-feeder: force a minimum of three providers (#536)

umee-network · Feb 10, 2022 · af8765f · af8765f
1 parent 20a2f25
commit af8765f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/price-feeder/CHANGELOG.md b/price-feeder/CHANGELOG.md
@@ -47,6 +47,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ### Features
 
+- [#536](https://github.com/umee-network/umee/pull/536) Force a minimum of three providers per asset.
 - [#502](https://github.com/umee-network/umee/pull/502) Faulty provider detection: discard prices that are not within 2𝜎 of others.
 
 ## [v0.1.0](https://github.com/umee-network/umee/releases/tag/price-feeder%2Fv0.1.0) - 2022-02-07

diff --git a/price-feeder/config/config.go b/price-feeder/config/config.go
@@ -158,15 +158,26 @@ func ParseConfig(configPath string) (Config, error) {
 		cfg.Server.ReadTimeout = defaultSrvReadTimeout.String()
 	}
 
+	pairs := make(map[string]map[string]struct{})
 	for _, cp := range cfg.CurrencyPairs {
 		if !strings.Contains(strings.ToUpper(cp.Quote), denomUSD) {
 			return cfg, fmt.Errorf("unsupported pair quote: %s", cp.Quote)
 		}
+		if _, ok := pairs[cp.Base]; !ok {
+			pairs[cp.Base] = make(map[string]struct{})
+		}
 
 		for _, provider := range cp.Providers {
 			if _, ok := SupportedProviders[provider]; !ok {
 				return cfg, fmt.Errorf("unsupported provider: %s", provider)
 			}
+			pairs[cp.Base][provider] = struct{}{}
+		}
+	}
+
+	for base, providers := range pairs {
+		if _, ok := pairs[base]["mock"]; !ok && len(providers) < 3 {
+			return cfg, fmt.Errorf("must have at least three providers for %s", base)
 		}
 	}
 

diff --git a/price-feeder/config/config_test.go b/price-feeder/config/config_test.go
@@ -136,15 +136,17 @@ base = "ATOM"
 quote = "USDT"
 providers = [
 	"kraken",
-	"binance"
+	"binance",
+	"huobi"
 ]
 
 [[currency_pairs]]
 base = "UMEE"
 quote = "USDT"
 providers = [
 	"kraken",
-	"binance"
+	"binance",
+	"huobi"
 ]
 
 [account]
@@ -184,7 +186,7 @@ global_labels = [["chain-id", "umee-local-beta-testnet"]]
 	require.Len(t, cfg.CurrencyPairs, 2)
 	require.Equal(t, "ATOM", cfg.CurrencyPairs[0].Base)
 	require.Equal(t, "USDT", cfg.CurrencyPairs[0].Quote)
-	require.Len(t, cfg.CurrencyPairs[0].Providers, 2)
+	require.Len(t, cfg.CurrencyPairs[0].Providers, 3)
 	require.Equal(t, "kraken", cfg.CurrencyPairs[0].Providers[0])
 	require.Equal(t, "binance", cfg.CurrencyPairs[0].Providers[1])
 }