-
Couldn't load subscription status.
- Fork 811
Block custom view update #7506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Block custom view update #7506
Conversation
|
Thanks @NguyenThuyLan for the PR 🙌 We will review it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @LanThuyNguyen apart from a couple of small points made as suggestions. Along with the existing "Custom Views for Block List" article this looks to cover what's needed.
| Before creating a Block Custom View, make sure you are familiar with the [Extension Registry in Umbraco](https://docs.umbraco.com/umbraco-cms/customizing/extending-overview/extension-registry/extension-registry). | ||
| You can also refer to the tutorial [Custom Views for Block List](https://docs.umbraco.com/umbraco-cms/tutorials/creating-custom-views-for-blocklist) for a step-by-step guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to use relative links here to the markdown files, e.g. ../extension-registry/register-extensions.md. They will be translated into real links when published on the website. But as markdown links they'll work when previewing in VS Code, as well as being future proof if the domain name would ever change.
| "forContentTypeAlias": "myElementTypeAlias", // insert element type alias here | ||
| "forBlockEditor": "block-list" // insert block type here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "forContentTypeAlias": "myElementTypeAlias", // insert element type alias here | |
| "forBlockEditor": "block-list" // insert block type here | |
| "forContentTypeAlias": "myElementTypeAlias", // insert element type alias here | |
| "forBlockEditor": "block-list" // insert block type(s) here |
Just fixing spacing.
📋 Description
Community Docs Project #7501