Release/17.0.0 #58
Open
Release/17.0.0 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated version.json to 17.0.0-rc1 - Updated global.json to .NET SDK 10.0.100-rc.1.25451.107 - Updated Directory.Build.props: - TargetFramework: net9.0 → net10.0 - EnablePackageValidation: true → false - PackageValidationBaselineVersion: 16.0.0 → 17.0.0 - Updated Directory.Packages.props: - TargetFramework: net9.0 → net10.0 - Umbraco.Cms: [16.0.0, 16.999.999) → [17.0.0-rc1, 17.999.999) - Umbraco.Cms.Web.Website: [16.0.0, 16.999.999) → [17.0.0-rc1, 17.999.999) - Umbraco.Cms.Web.BackOffice: [16.0.0, 16.999.999) → [17.0.0-rc1, 17.999.999) - Umbraco.Commerce: [16.0.0, 16.999.999) → [17.0.0-rc1, 17.999.999) - Updated individual project files to net10.0: - Umbraco.Commerce.ProductFeeds.Client.csproj - Umbraco.Commerce.ProductFeeds.Startup.csproj - Umbraco.Commerce.ProductFeeds.csproj - Removed obsolete code marked for removal in v17: - ProductFeedController.Xml method - UmbracoCommerceProductFeedSetting.FeedType property - ProductFeedSettingController.cs (entire file) - IProductFeedGeneratorFactory obsolete method overload - FeedGeneratorServiceBase.GenerateFeedAsync method - ProductFeedSettingReadModel.FeedType and FeedTypeName properties - IProductFeedGeneratorService obsolete method and default implementations - GoogleMerchantCenterFeedService obsolete override (class made internal) - ProductFeedSettingWriteModel.FeedType property - ProductFeedType.cs enum (entire file) - ProductFeedGeneratorFactory obsolete constructor and method (class made internal) - InfrastructureMappingProfile FeedType mapping - Fixed NPoco API changes for .NET 10: - Updated database query parameter passing to use array syntax - Updated frontend dependencies in package.json: - Package version: 16.0.0 → 17.0.0-rc1 - @umbraco-cms/backoffice: ^16.0.0 → ^17.0.0-rc.1 - @umbraco-commerce/backoffice: ^16.0.0 → ^16.4.0 (v17 not yet published) - @hey-api/openapi-ts: ^0.69.2 → ^0.85.0 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Umbraco Commerce Product Feeds package to version 17.0.0-rc1, introducing breaking changes by removing deprecated code and updating to .NET 10.0 and Node.js 22.x.
- Removed all deprecated v16 code including obsolete controllers, methods, properties, and the
ProductFeedTypeenum - Upgraded target framework from .NET 9.0 to .NET 10.0 across all projects
- Updated npm dependencies and Umbraco packages to v17 RC versions
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| version.json | Bumped version from 16.1.1 to 17.0.0-rc1 |
| global.json | Updated .NET SDK to 10.0.100-rc.2.25502.107 |
| Directory.Build.props | Changed target framework to net10.0, disabled package validation, updated baseline version |
| Directory.Packages.props | Updated target framework and Umbraco dependencies to 17.0.0-rc1 |
| azure-pipelines.yml | Upgraded Node.js version from 18.x to 22.x |
| src/Umbraco.Commerce.ProductFeeds/Umbraco.Commerce.ProductFeeds.csproj | Updated target framework to net10.0 |
| src/Umbraco.Commerce.ProductFeeds.Client/Umbraco.Commerce.ProductFeeds.Client.csproj | Updated target framework to net10.0 |
| src/Umbraco.Commerce.ProductFeeds.Client/frontend/package.json | Updated version and dependencies to 17.0.0-rc1, upgraded npm packages |
| src/Umbraco.Commerce.ProductFeeds.Client/frontend/.npmrc | Added custom registry for @umbraco-commerce packages |
| src/Umbraco.Commerce.ProductFeeds.Startup/Umbraco.Commerce.ProductFeeds.Startup.csproj | Updated target framework to net10.0 |
| src/Umbraco.Commerce.ProductFeeds.Web/Apis/Publics/ProductFeedController.cs | Removed obsolete Xml() method |
| src/Umbraco.Commerce.ProductFeeds.Web/Apis/Backoffice/Controllers/ProductFeedSettingController.cs | Removed obsolete controller class entirely |
| src/Umbraco.Commerce.ProductFeeds.Infrastructure/Implementations/ProductFeedSettingsService.cs | Updated database queries to use collection expression syntax |
| src/Umbraco.Commerce.ProductFeeds.Infrastructure/DtoMappings/InfrastructureMappingProfile.cs | Removed obsolete FeedType mapping |
| src/Umbraco.Commerce.ProductFeeds.Infrastructure/DbModels/UmbracoCommerceProductFeedSetting.cs | Removed obsolete FeedType property |
| src/Umbraco.Commerce.ProductFeeds.Core/Features/FeedSettings/Application/ProductFeedType.cs | Deleted obsolete enum file |
| src/Umbraco.Commerce.ProductFeeds.Core/Features/FeedSettings/Application/ProductFeedSettingWriteModel.cs | Removed obsolete FeedType property |
| src/Umbraco.Commerce.ProductFeeds.Core/Features/FeedSettings/Application/ProductFeedSettingReadModel.cs | Removed obsolete FeedType properties and unused import |
| src/Umbraco.Commerce.ProductFeeds.Core/Features/FeedGenerators/Application/IProductFeedGeneratorService.cs | Removed default implementations, made properties required |
| src/Umbraco.Commerce.ProductFeeds.Core/Features/FeedGenerators/Application/IProductFeedGeneratorFactory.cs | Removed obsolete method overload and default implementation |
| src/Umbraco.Commerce.ProductFeeds.Core/Features/FeedGenerators/Implementations/FeedGeneratorServiceBase.cs | Removed obsolete GenerateFeedAsync method |
| src/Umbraco.Commerce.ProductFeeds.Core/Features/FeedGenerators/Implementations/GoogleMerchantCenterFeedService.cs | Made class internal, removed obsolete method |
| src/Umbraco.Commerce.ProductFeeds.Core/Features/FeedGenerators/Implementations/ProductFeedGeneratorFactory.cs | Made class internal, removed obsolete constructor and method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <PropertyGroup> | ||
| <EnablePackageValidation>true</EnablePackageValidation> | ||
| <PackageValidationBaselineVersion>16.0.0</PackageValidationBaselineVersion> | ||
| <EnablePackageValidation>false</EnablePackageValidation> |
There was a problem hiding this comment.
[nitpick] Package validation has been disabled for this release. While this is acceptable for a major version release (17.0.0) with breaking changes, consider re-enabling it after the release to ensure future changes maintain backward compatibility.
Suggested change
| <EnablePackageValidation>false</EnablePackageValidation> | |
| <EnablePackageValidation>true</EnablePackageValidation> |
| "nanoid": "^5.1.5" | ||
| "@hey-api/client-axios": "^0.9.1", | ||
| "@umbraco-cms/backoffice": "^17.0.0-rc.1", | ||
| "@umbraco-commerce/backoffice": "17.0.0-rc1", |
There was a problem hiding this comment.
Pre-release version format inconsistency: @umbraco-cms/backoffice uses "rc.1" (with dot) while @umbraco-commerce/backoffice uses "rc1" (without dot). According to semantic versioning, pre-release versions should use dot notation (e.g., "17.0.0-rc.1"). Ensure both packages are using the correct pre-release format for their respective registries.
Suggested change
| "@umbraco-commerce/backoffice": "17.0.0-rc1", | |
| "@umbraco-commerce/backoffice": "17.0.0-rc.1", |
| "nanoid": "^5.1.5" | ||
| "@hey-api/client-axios": "^0.9.1", | ||
| "@umbraco-cms/backoffice": "^17.0.0-rc.1", | ||
| "@umbraco-commerce/backoffice": "17.0.0-rc1", |
There was a problem hiding this comment.
[nitpick] Inconsistent version format: @umbraco-cms/backoffice uses caret (^) while @umbraco-commerce/backoffice doesn't. For consistency, both dependencies should use the same version prefix format (either both with ^ or both without).
Suggested change
| "@umbraco-commerce/backoffice": "17.0.0-rc1", | |
| "@umbraco-commerce/backoffice": "^17.0.0-rc1", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.