Media types: Handle null configured file extensions when populating allowed media types (closes #20620) #20635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes: #20620
Description
Seems with legacy data the configuration for
fileExtensionsunder an upload field data type can be null, which we aren't expecting in backend code. So this PR just defensively ensures we are working with an empty collection and never null.Testing
There's a method using uSync described in the linked issue, but I replicated the problem and verified the fix with the following:
Restarted to clear caches
Made a call to the following:
/umbraco/management/api/v1/item/media-type/allowed?fileExtension=mp3&skip=0&take=100Reset my database with:
Release
On approval and merge this will go into 16.4. Let me know if you are happy this goes into 17.0 which I would say is OK given we are in the beta period still. Otherwise it'll be 17.0.