Storybook: Story for reviewing Lucide icons #20631
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslyngsoe
changed the title
Co-authored-by: nielslyngsoe <[email protected]>
Copilot
AI
changed the title
[WIP] Add an overview of unregistered Lucide icons to CMS Storybook
Add Storybook story for unregistered Lucide icons
Oct 23, 2025
Copilot finished work on behalf of
nielslyngsoe
October 23, 2025 13:42
nielslyngsoe
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Storybook story that displays all Lucide icons available in the library, highlighting which ones are already registered in the CMS icon registry versus those that are unregistered. This helps developers discover icons that could potentially be added to the CMS.
Key Changes:
- Created a new Storybook story that dynamically compares registered icons from
icon-dictionary.jsonwith all available Lucide icons - Added static file serving configuration in Storybook to access Lucide icon assets
- Implemented visual differentiation between registered and unregistered icons using border styling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/available-lucide-icons.stories.ts | New story that fetches and displays all Lucide icons with registration status and statistics |
| src/Umbraco.Web.UI.Client/.storybook/main.ts | Added configuration to serve lucide-static directory as static assets in Storybook |
src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/available-lucide-icons.stories.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/available-lucide-icons.stories.ts
Show resolved
Hide resolved
auto-merge was automatically disabled
October 24, 2025 09:19
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new Storybook story that displays all Lucide icons. This makes it easy for developers to discover which icons are available in the Lucide library but haven't been added to the CMS yet.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
iojs.orgcurl -q --fail --compressed -L -s REDACTED -o -(dns block)storybook.js.orgnode /home/REDACTED/work/Umbraco-CMS/Umbraco-CMS/src/Umbraco.Web.UI.Client/node_modules/.bin/storybook dev -p 6006(dns block)uui.umbraco.comnode /home/REDACTED/work/Umbraco-CMS/Umbraco-CMS/src/Umbraco.Web.UI.Client/node_modules/.bin/storybook dev -p 6006(dns block)If you need me to access, download, or install something from one of these locations, you can either: