Skip to content

Conversation

@NguyenThuyLan
Copy link
Contributor

Prerequisites

This test needs some helper methods in this PR umbraco/Umbraco.Playwright.Testhelpers#299

Description

These tests ensure the block custom view appears in a specific Block Type, appears in a specific Block Element, and can get content adn setting value

Copy link
Contributor

@nhudinh0309 nhudinh0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some comments

Copy link
Contributor

@nhudinh0309 nhudinh0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
You can merge this after updating the indentation space from 4 to 2.

@NguyenThuyLan NguyenThuyLan merged commit e155fdf into main Nov 6, 2025
25 of 26 checks passed
@NguyenThuyLan NguyenThuyLan deleted the v16/QA/block-custom-view branch November 6, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants