- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.8k
Block Custom View: Add tests for create and using block custom view #20472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            NguyenThuyLan
  wants to merge
  9
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
v16/QA/block-custom-view
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    nhudinh0309
  
              
              requested changes
              
                  
                    Oct 14, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some comments
        
          
                ...t/tests/ExtensionRegistry/AdditionalSetup/App_Plugins/block-custom-view/umbraco-package.json
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/BlockCustomView.spec.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/BlockCustomView.spec.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/BlockCustomView.spec.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/BlockCustomView.spec.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/BlockCustomView.spec.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/BlockCustomView.spec.ts
          
            Show resolved
            Hide resolved
        
              
          
                tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/BlockCustomView.spec.ts
          
            Show resolved
            Hide resolved
        
              
          
                tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/BlockCustomView.spec.ts
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                tests/Umbraco.Tests.AcceptanceTest/tests/ExtensionRegistry/BlockCustomView.spec.ts
          
            Show resolved
            Hide resolved
        
      …ckCustomView.spec.ts Co-authored-by: Nhu Dinh <[email protected]>
…ckCustomView.spec.ts Co-authored-by: Nhu Dinh <[email protected]>
…ckCustomView.spec.ts Co-authored-by: Nhu Dinh <[email protected]>
…ckCustomView.spec.ts Co-authored-by: Nhu Dinh <[email protected]>
…6/QA/block-custom-view
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Prerequisites
This test needs some helper methods in this PR umbraco/Umbraco.Playwright.Testhelpers#299
Description
These tests ensure the block custom view appears in a specific Block Type, appears in a specific Block Element, and can get content adn setting value