Skip to content

Set value of configured grid columns #20436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Set value of configured grid columns #20436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {

Check notice on line 1 in src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.context.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Code Health Review (main)

✅ Getting better: Overall Code Complexity 

The mean cyclomatic complexity decreases from 4.53 to 4.50, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
UmbBlockGridLayoutModel,
UmbBlockGridTypeAreaType,
UmbBlockGridTypeModel,
Expand Down Expand Up @@ -385,7 +385,7 @@
hostEl.setAttribute('data-area-alias', areaType?.alias ?? '');
hostEl.setAttribute('data-area-col-span', areaType?.columnSpan?.toString() ?? '');
hostEl.setAttribute('data-area-row-span', areaType?.rowSpan?.toString() ?? '');
hostEl.style.setProperty('--umb-block-grid--grid-columns', areaType?.columnSpan?.toString() ?? '');
hostEl.style.setProperty('--umb-block-grid--grid-columns', this.#layoutColumns.getValue()?.toString() ?? '');

Check notice on line 388 in src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.context.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Code Health Review (main)

✅ Getting better: Complex Method 

UmbBlockGridEntriesContext.gotBlockParentEntry decreases in cyclomatic complexity from 22 to 21, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
hostEl.style.setProperty('--umb-block-grid--area-column-span', areaType?.columnSpan?.toString() ?? '');
hostEl.style.setProperty('--umb-block-grid--area-row-span', areaType?.rowSpan?.toString() ?? '');
this.#setupAllowedBlockTypes();
Expand Down
Loading