Resolves issues related to the setting of a schedule for content publishing#17868
Resolves issues related to the setting of a schedule for content publishing#17868leekelleher merged 36 commits intov15/devfrom
Conversation
# Conflicts: # src/Umbraco.Cms.Api.Management/Controllers/Document/ByKeyDocumentController.cs # src/Umbraco.Cms.Api.Management/Factories/IDocumentPresentationFactory.cs # src/Umbraco.Cms.Api.Management/ViewModels/Document/DocumentVariantResponseModel.cs # src/Umbraco.Core/Services/ContentPublishingService.cs # src/Umbraco.Web.UI.Client/src/packages/core/workspace/conditions/manifests.ts # src/Umbraco.Web.UI.Client/src/packages/core/workspace/conditions/types.ts # src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/publish-with-descendants/workspace-action/manifests.ts
|
I've combined this with the work @Migaroez did in #17535, as we'd overlapped slightly. Have picked out his updates and ensured they worked with mine in the UI. It's working a lot better now in terms of saving a schedule and having it displayed in the UI again so you can view and edit it. The only issue I can still see is for variant content, in that when you view or set the schedule, you don't see the previous schedule of the non-active variant. E.g. here I'm looking at English and have clicked the Schedule button: Which correctly shows the previously set English schedule and has the Italian one hidden. But if I click to view or set the Italian one, I don't see the previously set schedule: It's OK though if I've made a change to the Italian content. I can kind of see why... but it seems that this dialog has really been built around displaying data for the active or changed variants. Here that doesn't seem right - seems we should be able to see and set a schedule for a non-active and non-changed variant, |
…the server this way we ensure the datetime contains the offset
… the actual values
|
I have handled @AndyButland's issue by sending all the options as values to the modal and adding a new data option called |
leekelleher
left a comment
There was a problem hiding this comment.
Tested it out, it's all looking good. Great work here!
The only thing I picked up on was that when the Schedule action is triggered, the notification toast says "Document published".
We'll need to review how the notification from the publish() method in document-publishing.repository.ts is handled.
If we want to handle that in a separate PR, then I'm happy to approve on this PR.
…lly before finally setting the value from the updated internal values upon submit
…raco/Umbraco-CMS into v15/bugfix/scheduled-publish
leekelleher
left a comment
There was a problem hiding this comment.
Tested latest fixes, all looking good. 🚀
| documentType: 'Document Type', | ||
| editing: 'Editing', | ||
| expireDate: 'Remove at', | ||
| expireDate: 'Remove At', |
There was a problem hiding this comment.
Just a heads up @AndyButland: screen readers read capitalization differently, so it will be more like: "Remove. At." than "Remove at".
There was a problem hiding this comment.
Thanks. I didn't know that but makes sense now you point it out.
Trying to recall why I changed this - I think it was aligning with other labels where this is displayed, but can't see it now. Will review and revert,


Prerequisites
Addresses issues raised in #17031, tracked under AB 45476 (internal HQ tracker)
Also fixes #17830 tracked under AB 47430
Also fixes #18297 tracked under AB 48986
Description
Reported issue:
#17031 describes several issues related to the setting and reading of scheduled publishing details:
Resolution:
With the PR merged, these issues will be addressed as follows:
To Test:
umbracoContentSchedule), which will indicate that issue 5 is resolved.Caveats