Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Ultralytics Retry action #2300

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

pderrenger
Copy link
Member

@pderrenger pderrenger commented Nov 8, 2024

This Ultralytics PR refactors code to improve performance and readability. 🔄

Key changes include:

  • 🚀 Optimized various functions for faster execution.
  • 🧩 Simplified complex logic for better understanding and maintenance.
  • 🗑️ Removed redundant code to streamline operations.
  • 📚 Improved code structure and organization.

These changes aim to enhance the overall quality and efficiency of the code. 🌟

Learn more about Ultralytics:

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

This update improves the continuous integration workflow by changing the retry logic for link checks in documentation.

📊 Key Changes

  • Replaced the retry action from nick-invision/retry@v3 with ultralytics/actions/retry@main.
  • Updated parameter names from retry_wait_seconds to retry_delay_seconds, max_attempts to retries, and command to run for compatibility with the new action.

🎯 Purpose & Impact

  • Consistency: Using the ultralytics/actions/retry action ensures consistency across Ultralytics projects, potentially leading to more tailored and robust integration testing.
  • Maintenance: Simplifies maintenance and integration processes by relying on Ultralytics' own action, which may have more relevant support and updates aligned with the project's needs.
  • Reliability: Improves the reliability of checking for broken links, which is important for maintaining up-to-date documentation and enhancing user experience.

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request labels Nov 8, 2024
@UltralyticsAssistant
Copy link
Member

👋 Hello @pderrenger, thank you for submitting an ultralytics/yolov3 🚀 PR! This is an automated response to help you ensure a smooth integration of your contributions into our codebase. An Ultralytics engineer will review your submission shortly. Meanwhile, please ensure the following checklist is complete:

  • Define a Purpose: Please make sure the purpose of your changes is clearly explained in your PR description, including any relevant issues they address. Concise and clear commit messages are appreciated.
  • Synchronize with Source: Double-check that your PR is in sync with the main branch of ultralytics/yolov3. Use the 'Update branch' button or run git pull and git merge main locally if needed.
  • Ensure CI Checks Pass: Ensure all Ultralytics Continuous Integration (CI) checks pass. If any check fails, please investigate and fix any issues.
  • Update Documentation: Update documentation as necessary for any new or changed features.
  • Add Tests: Where applicable, add or update tests that cover your changes, and confirm that all tests are passing successfully.
  • Sign the CLA: If this is your first PR to Ultralytics, please sign our Contributor License Agreement by stating: "I have read the CLA Document and I sign the CLA" in a comment.
  • Minimize Changes: Aim to keep your changes at a minimum, focusing only on essential bug fixes or feature enhancements. As Bruce Lee once said: "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is."

For additional guidance, feel free to consult our Contributing Guide.

If you're reporting a bug, please remember to include a Minimum Reproducible Example (MRE) to help us understand and address the issue efficiently.

🌟 Thank you for contributing to Ultralytics' projects! If you have any questions or need further assistance, do not hesitate to ask. 🚀

@pderrenger pderrenger merged commit 6438bb5 into master Nov 8, 2024
6 checks passed
@pderrenger pderrenger deleted the refactor-20241108121610 branch November 8, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops GitHub Devops or MLops enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants