Skip to content

WIP: BDE Integrator refactor #24

Merged
SMijin merged 4 commits intodev-v1.3.0from
smijin-bde-refactor
Jun 30, 2025
Merged

WIP: BDE Integrator refactor #24
SMijin merged 4 commits intodev-v1.3.0from
smijin-bde-refactor

Conversation

@SMijin
Copy link
Contributor

@SMijin SMijin commented May 29, 2025

Moved from equal sized substeps to variable size substeps in BDE Integrator internal step control.

Consolidation now happens at every step, the integrator attempts to take the requested step, and then uses the old stepMultiplier to divide the step size if it fails.

If it succeeds and the number of nonlinear iterations is below minNonlinIters, it will attempt to increaste the timestep by 50% (or whatever remains of the requested total timestep)

stepDecrament, consolidationInterval, and initialNumInternalSteps have all been removed and will be ignored in the config.

Also added the option to allow lazy timestepping, which is triggered when the integrator has a successful solve on its first try with only one 1 nonlinear iteration. After this, all calls to the integrator evolve only time. This should speed up steady state runs.

@SMijin SMijin self-assigned this May 29, 2025
@SMijin SMijin added the enhancement New feature or request label May 29, 2025
@SMijin SMijin changed the base branch from master to dev-v1.3.0 May 29, 2025 18:51
@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev-v1.3.0@052c506). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...nded_support/initialization_support_procedures.f90 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-v1.3.0      #24   +/-   ##
=============================================
  Coverage              ?   54.28%           
=============================================
  Files                 ?      239           
  Lines                 ?    10109           
  Branches              ?        0           
=============================================
  Hits                  ?     5487           
  Misses                ?     4622           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@sleigh2022 sleigh2022 Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From discussion 25 Jun:

  • Scaling timestep (commit 9c73ba4) may need to be reverted then pushed to a separate PR since this might lead to unwanted bugs. Afterwards, PR WIP: BDE Integrator refactor  #24 can be safely closed.

  • All other features work from my end, and substep elapsed time is a useful addition to the output stream.

Copy link
Collaborator

@sleigh2022 sleigh2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment from 25 June - consider reverting 9c73ba4 (setting scaledRequestedTimestep to max of [scaled, requested]) before merge

@SMijin SMijin merged commit 3c008dd into dev-v1.3.0 Jun 30, 2025
@SMijin SMijin deleted the smijin-bde-refactor branch June 30, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants