Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-v1.3.0 #24 +/- ##
=============================================
Coverage ? 54.28%
=============================================
Files ? 239
Lines ? 10109
Branches ? 0
=============================================
Hits ? 5487
Misses ? 4622
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
From discussion 25 Jun:
-
Scaling timestep (commit 9c73ba4) may need to be reverted then pushed to a separate PR since this might lead to unwanted bugs. Afterwards, PR WIP: BDE Integrator refactor #24 can be safely closed.
-
All other features work from my end, and substep elapsed time is a useful addition to the output stream.
sleigh2022
left a comment
There was a problem hiding this comment.
See comment from 25 June - consider reverting 9c73ba4 (setting scaledRequestedTimestep to max of [scaled, requested]) before merge
Moved from equal sized substeps to variable size substeps in BDE Integrator internal step control.
Consolidation now happens at every step, the integrator attempts to take the requested step, and then uses the old stepMultiplier to divide the step size if it fails.
If it succeeds and the number of nonlinear iterations is below minNonlinIters, it will attempt to increaste the timestep by 50% (or whatever remains of the requested total timestep)
stepDecrament, consolidationInterval, and initialNumInternalSteps have all been removed and will be ignored in the config.
Also added the option to allow lazy timestepping, which is triggered when the integrator has a successful solve on its first try with only one 1 nonlinear iteration. After this, all calls to the integrator evolve only time. This should speed up steady state runs.