Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4083 +/- ##
==========================================
- Coverage 46.47% 46.44% -0.04%
==========================================
Files 123 123
Lines 28902 28938 +36
==========================================
+ Hits 13432 13440 +8
- Misses 15470 15498 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ) | ||
| return len_blkt_outboard_segment_poloidal | ||
|
|
||
| def blanket_module_poloidal_height(self): |
Collaborator
There was a problem hiding this comment.
Isn't this function now completely duplicate and should be removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a more detailed and flexible calculation of blanket module geometry in the
process/blanket_library.pyfile. The main improvement is the replacement of a generic poloidal height calculation with specialized methods that account for different machine shapes (D-shaped vs. elliptical) and divertor configurations. This allows for more accurate modeling of the blanket module segment lengths in both inboard and outboard regions.Geometry calculation enhancements:
blanket_library.pyfor calculating segment lengths:calculate_dshaped_inboard_blkt_segment_poloidal,calculate_dshaped_outboard_blkt_segment_poloidal,calculate_elliptical_inboard_blkt_segment_poloidal, andcalculate_elliptical_outboard_blkt_segment_poloidal. These methods use plasma geometry and divertor configuration parameters for more precise calculations.set_blanket_module_geometrymethod to select the appropriate calculation method based on machine and blanket shape, replacing the previous genericblanket_module_poloidal_heightcall. Segment lengths are now computed using the new specialized methods for both inboard and outboard modules.## DescriptionChecklist
I confirm that I have completed the following checks: