-
Notifications
You must be signed in to change notification settings - Fork 17
724 cpttf and cpttf max error catching integer turns option #3114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cjwgriesel
wants to merge
9
commits into
main
Choose a base branch
from
724-cpttf-and-cpttf_max-error-catching-integer-turns-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
724 cpttf and cpttf max error catching integer turns option #3114
cjwgriesel
wants to merge
9
commits into
main
from
724-cpttf-and-cpttf_max-error-catching-integer-turns-option
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorris-uk
requested changes
May 14, 2024
Contributor
jmorris-uk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove HDF update. Otherwise looks fine.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be included in this pull request.
Collaborator
|
This PR is very outdated, so I have redone this in #4034. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added exclusion for constraint 77 fcpttf if ixc =60 (cpttf) is selected. Cannot have constraint icc = 77 fcpttf with iteration value ixc = 60 cpttf.
Exclusion for ixc = 60 if i_tf_turns_integer == 1. Cannot have iterated itv ixc = 60 with i_tf_turns_integer == 1.
Exclusion for ixc = 60 if t_turn_tf or t_cable_tf is selected. Cannot have iterated itv ixc == 60 cpttf with t_turn_tf input or t_cable_tf is input.
Added a Warning that if i_tf_turns_integer == 0 and if t_turn_tf or t_cable_tf is selected then cpttf is calculated. It will over write any value of cpttf if it is inputted.
Added a Warning that if i_tf_turns_integer == 0 and if cpttf = 70000.0 and if t_turn_tf or t_cable_tf is not selected then the default value of cpttf has been used if no value of cpttf has been inputted.
Added improved method of detecting if values have been inputted by having three boolean flags t_turn_tf_is_input, t_cable_tf_is_input and cpttf_max_is_input. If any are true then a value has been inputted. Note that at present the cpttf_max_is_input flag is not used as using cpttf_max did not seem to have any effect?? Default value of cpttf_max = 90000.0.
new warnings and errors added to errorlist.json 282 to 286.
Noticed an error in sctfcoil.py and corrected it. i.e.
po.ovarre(
self.outfile,
"WP cross section area (per coil) (m2)",
"(aswp)",
sctfcoil_module.awptf,
)
fixed it by providing the output for both aswp and awptf. This necessitated modifying the test results as the output had changed.
Added a modification to hdf_to_scatter_plot.py where the font size can be selected manually (default set 6) and called it hdf_to_scatter_plot1.py. Not related to this Issue but it is a useful modification for scatterplots.