Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial report commit #28

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Initial report commit #28

merged 2 commits into from
Jan 30, 2024

Conversation

harisood
Copy link
Member

No description provided.

@harisood
Copy link
Member Author

harisood commented Dec 1, 2023

Ok this is actually taking longer than I expected, so am just gonna focus now on getting the raw notes uploaded, and then come back to summaries etc.

For summaries/next steps, I think Lucy has done some great work on this already (baked into the slides). We just need to flesh out the slides slightly more in these descriptions! I have done one for the Multi-TRE analysis breakout

@harisood
Copy link
Member Author

harisood commented Dec 1, 2023 •
edited
Loading

Jobs to do:

  • Transcribe handwritten notes
  • Ensure raw notes are anonymous
  • Decide if we keep attendee lists in here
  • Write an overview of summary and next steps (based on Lucy's pres too) for each breakout - see here
  • Ensure uniformity across rendering of notes

@Davsarper
Copy link
Member

I am going to have to leave soon today, but can have a stab at this tomorrow.
Are each of the files for each of the breakout included here meant to be the raw notes or the summaries?
If it is the summaries can we use this structure (so we can practically copy past from sumnaries hackmd):

  • Title
    • Link to raw notes: TBD for all until we create them (copy past hackmds dropping names)
  • Summary
  • Roadmap

We said we would drop atttendees I think, although open to reconsider at a community level.

I see 'Index' already has an updated description and includes the report from the keynote, imo it would be good to also add a bit of a reflection from the day (how happy we are seeing everyone there, hwo we took it as a key point it the life of the community...)

@harisood harisood marked this pull request as ready for review December 19, 2023 18:47
@harisood harisood mentioned this pull request Dec 19, 2023
Closed
7 tasks
@harisood
Copy link
Member Author

Ugh Idk why that link check is failing, @manics any ideas?

@harisood harisood requested review from manics and Davsarper December 19, 2023 18:56
Davsarper
Davsarper reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@Davsarper Davsarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No time for 3 last files so will come back to it:

  • Need anonymisation
  • Some copy pasted format causing issues, made the neessary suggestions I hope
  • Took out images of handwritten notes, they make it too long

Davsarper
Davsarper requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Davsarper Davsarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final 3 files reviewd, also made suggestions to take out the title 'Attendees' where I had failed to do so.

manics
manics reviewed Jan 25, 2024
View reviewed changes
docs/events/wg_workshops/2023-09-04-september-meeting/index.md Outdated

- Talk to HDR UK about what they should include in this landscape, and work together with them on co-creating solutions.

The session ended with a short Q&A, which can be found on the [recording of the session](https://www.youtube.com/watch?v=ipfU4FdjYGM).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you know the timestamp we can include it in the link (append&t=<MINUTES>m<SECONDS>s

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We included "chapters" in the video
00:00 Introduction
03:57 DARE UK updates
09:05 Keynote by Emily Jefferson
44:46 Q&A
51:16 Next steps for the day

@manics
Copy link
Member

manics commented Jan 25, 2024 

(events/wg_workshops/2023-09-04-september-meeting/index: line   36) broken    https://www.turing.ac.uk/ - 403 Client Error: Forbidden for url: https://www.turing.ac.uk/

I suspect the Turing website is treating GitHub link checks as suspicious traffic and blocking it

@Davsarper
Copy link
Member

Davsarper commented Jan 25, 2024 •
edited
Loading

I suspect the Turing website is treating GitHub link checks as suspicious traffic and blocking it

That would be very Turing, @JimMadge have you had a similar issue before?

@manics
Copy link
Member

manics commented Jan 25, 2024

This PR is too big and has been open too long 😄

I think the best approach now is to get any final changes in, and when we're happy with the content I'll rebase this branch, squash, and force push, to remove all history (so we'll end up with a single commit) before merging

@Davsarper
Copy link
Member

Definitely! I am now struggling with changes from everyone. Agreed, let's finalise content which I think we are happy with? I will approve your suggestions @manics they all LGTM

@manics manics marked this pull request as draft January 25, 2024 14:56
@manics
Copy link
Member

manics commented Jan 25, 2024

I've marked this as draft as a reminder to force push/rebase to remove the history. I'll do that as soon as someone tells me to 😄

Davsarper
Davsarper reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@Davsarper Davsarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harmonised title hierarchy: roadmap and quesitons were someitmes wihtin raw notes sometimes not, they should be as they are titles from the hackmd templates

@Davsarper
Copy link
Member

As soon as I said content was good I noticed titles were quite inconsistent... should be good now? @manics if you like how it looks now commit (or tell me to) and go ahead with the GHmongery?
Thanks for tackling this ❤️

Davsarper
Davsarper previously approved these changes Jan 25, 2024
View reviewed changes
@harisood @Davsarper @manics
Initial report commit
7d2e165 
Welcome, keynote and lightning talks

Initial structure

Keynote summary

Lightning talks

Multi-TRE analysis breakout

TRe sustainability and operations breakout

Breakout - Python & R

PPIE breakout

SATRE breakout

Standardisation tension breakout

Data harmonisation breakout

Final breakouts

AI/ML approach notes

TRE sustainability

Allowlists

PPIE

On prem vs cloud

NHS SDEs

SATRE

standardisation tensions

Data harmonisation

Sight unseen

Community governance

TOC tree

Fixing broken link

Fixing broken link v2

Apply suggestions from code review

Co-authored-by: Davsarper <[email protected]>

Run pre-commit

linkcheck_ignore: https://www.turing.ac.uk/

Remove attendee names

Co-authored-by: Davsarper <[email protected]>

Code review changes

pre-commit

Update docs/events/wg_workshops/2023-09-04-september-meeting/index.md

Co-authored-by: Simon Li <[email protected]>

Update docs/events/wg_workshops/2023-09-04-september-meeting/index.md

Co-authored-by: Simon Li <[email protected]>

Apply suggestions from code review: heading levels

Co-authored-by: Davsarper <[email protected]>
@manics manics force-pushed the 8-september-report branch from c6d3fda to 7d2e165 Compare January 25, 2024 15:44
@manics manics marked this pull request as ready for review January 25, 2024 15:47
@JimMadge
Copy link

I suspect the Turing website is treating GitHub link checks as suspicious traffic and blocking it

That would be very Turing, @JimMadge have you had a similar issue before?

Yes, not just GitHub. In general I don't think I've found a link checker that works out of the box. I think the webserver rejects requests that don't have the headers saying they are a browser. It might work if you spoof Firefox, for example. But I generally add *turing.ac.uk to my exclude list 😄.

manics
manics approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@harisood
Copy link
Member Author

Apologies if my 'this works for me' file naming and structure made this harder than it needed to be... and if it did plz lmk how to improve in the future!

@Davsarper Davsarper merged commit 212369f into main Jan 30, 2024
@manics manics deleted the 8-september-report branch May 16, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics manics approved these changes

@Davsarper Davsarper Davsarper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harisood @Davsarper @manics @JimMadge