Conversation
… created generate map method
…reated skeletons for generate player and parse input
…throw for more specification on moves. I also created default constructors and added json parsing macros.
…throw for more specification on moves. I also created default constructors and added json parsing macros.
…s the input parsing to allow for combo input leniency
…tboxes will be stored in the hitbox data class until called to create the temporary fixtures
…ges mid attack like a lunge kick. Also updated the json to match
…reation into different methods as well as created different initiate move overrides the initiate move method as well as created a method to clean up inputs
…next frame method
…next frame method
…lor to denote state change
…hitboxes and changes the velocity based on the frame
…air attack patterns for clarity
ishitarao
left a comment
ishitarao
left a comment
There was a problem hiding this comment.
Bob Game is the culmination of your efforts this semester; I hope you're proud of what you've made (I thought you were going to call it Antares, given the namespace/file names). I also hope you decide to continue working on Bob Game and then make it a public repository.
While doing the bare minimum for your README in the context of this assignment is okay, I really recommend learning how to use Markdown and learning how to create descriptive, well-written READMEs. If you want people to look at, appreciate, and use your code, then a good README is key.
I'm happy to see how much you've improved over this semester, and I hope you'll keep writing good-looking code. Good luck. :)
| /**Json macro*/ | ||
| NLOHMANN_DEFINE_TYPE_INTRUSIVE(AirAttacks, neutral_air, forward_air, | ||
| back_air, up_air, down_air); | ||
|
|
There was a problem hiding this comment.
forward_air. back_air. up_air. down_air. Long ago, the four nations lived in harmony. Then, everything changed when the up_air nation attacked. Only the neutral_air, master of all four elements, could stop them. But when the world needed him the most, he vanished. A 100 years passed and my brother and I discovered the new neutral_air, a down_airbender named Aang. And although his down_airbending skills are great, he has a lot to learn before he's ready to save anyone. But I believe, Aang can save the world.
There was a problem hiding this comment.
(As a sidenote, the macros look great!)
| Attack neutral_air; | ||
| /**forward Air Attack*/ | ||
| Attack forward_air; | ||
| /**back Air Attack*/ | ||
| Attack back_air; | ||
| /**up Air Attack*/ | ||
| Attack up_air; | ||
| /**down Air Attack*/ | ||
| Attack down_air; |
There was a problem hiding this comment.
For related variables, you can use a single CDoc describing their purpose.
| b2Body* player_body_; | ||
|
|
||
| /**Bool that shows whether a move is in progress*/ | ||
| bool is_move_in_progress_ = false; |
There was a problem hiding this comment.
Don't initialise non-const variables in the header file.
| /**Color R value*/ | ||
| int r; | ||
| /**Color G value*/ | ||
| int g; | ||
| /**Color BR value*/ | ||
| int b; |
There was a problem hiding this comment.
An std::tuple would be good here, although I'm pretty sure Cinder already has something for RGB colours.
There was a problem hiding this comment.
I did it like this to avoid making the macro even more messy as I didn't want to mess around too much with getting tuples to register, though they might already.
| float x; | ||
| /**circle y position*/ | ||
| float y; |
There was a problem hiding this comment.
An std::pair is always recommended for x-y pairs.
2 participants
-Added circle drawing function
-completed input parser
-completed input maps
-completed json for character data
-*Created a new class to handle moves(very time consuming) :(
-Moved certain data structs into different files for better organization
-added specs and a lot more comments
-added visuals for the moves
-refactored move models to allow for changing velocity and multiple sets of hitboxes
I'm tired but happy with what I've learned during this project and throughout the overall semester. A lot of that is thanks to you. So thank you very much for all of the help you have given me.
https://cdn.discordapp.com/attachments/501225658060636171/786092990648549396/bueno.jpg