Conversation
|
The comment on your pull request should be a development log for the week. Note that I can't grade you on documentation (10%) without the development log, so please try to add that as soon as you're able. |
ishitarao
reviewed
Nov 20, 2020
|
|
||
| public: | ||
|
|
||
| std::string move_image_; |
There was a problem hiding this comment.
I would imagine that the image for a move would remain consistent throughout your game; do consider making this const.
Contributor
Author
|
|
You're good to go in terms of a Development Log. Make sure you update your PROPOSAL.md by adding the title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reversed the pull request so I don't have to spend any more time on this weird stuff for now.