Repository navigation
Update @uigraph/sdk to 1.2.19 - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
@uigraph/sdkfrom 1.2.17 to 1.2.19 to get the latest converter fixes.Before and after
Before: Saving a diagram changed node ids such as
http_apiorworker2toA,B,C. Context fields that came from Mermaid had no stable id.After: Node ids that start with a letter and contain only letters, digits and underscores stay the same (SDK 1.2.18). Each context field from Mermaid uses its key as its id (SDK 1.2.19).
Risk
Only the diagram conversion code from the SDK changes. Diagrams that use ids with underscores or digits will now keep those ids when you save them, so the saved
.mmdfiles and context keys can look different than before. Reverting this PR fully undoes it.Evidence
nr typecheckpasses with SDK 1.2.19 installed. I did not run the app or the tests, and I did not save a diagram to check the new ids.What changed
Improvements:
@uigraph/sdkto^1.2.19inpackage.jsonand the lockfile.Checklist
@uigraph/sdk1.2.19http_apiand make sure that the ids do not change