Skip to content

Add tests for {software,bot}@mil.ufl.edu #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbrxyz opened this issue Mar 30, 2025 · 3 comments
Open

Add tests for {software,bot}@mil.ufl.edu #99

cbrxyz opened this issue Mar 30, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@cbrxyz
Copy link
Member

cbrxyz commented Mar 30, 2025

We should add CI tests to ensure that our account credentials (or at least the ones that are stored in CI) are still operational and still allow us access to the accounts.

@cbrxyz cbrxyz added the enhancement New feature or request label Mar 30, 2025
@TheRickyZhang TheRickyZhang self-assigned this Mar 31, 2025
@TheRickyZhang
Copy link
Contributor

I can take this. Could I get more detail about the what the specific accounts are and access to them mean? I searched for @mil.ufl.edu in the codebase and couldn't find anything except for the legacy docs building.

@cbrxyz
Copy link
Member Author

cbrxyz commented Mar 31, 2025

You can just submit a PR that adds a GitHub action check that checks whether the inbox of an arbitrary SMTP account can be seen.

You can add it to .github/workflows/healthcheck.yaml. It should take in a GitHub secret for the account server, email address, username, password, etc.

The check succeeds if the number of messages in the inbox can be fetched, and fails if not (ie, an auth/networking error has occurred).

@TheRickyZhang
Copy link
Contributor

TheRickyZhang commented Apr 7, 2025

I added the account-access command in healthcheck.yaml. Since I can't access the secrets I cannot test this out, but the account information is expected to be under the ACCOUNTS_JSON variable, with data form:
{
"accounts": [
{ "name": "acc1", "server": "smtp1.example.com" },
{ "name": "acc2", "server": "smtp2.example.com" }
]
}
(this organizes for possibility of multiple accounts, but if we only have static few we can use single variables).
Please let me know when you update the secrets, and I can verify from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants