Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension-utils): add a new package, extension-utils #5970

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

nperez0111
Copy link
Contributor

@nperez0111 nperez0111 commented Dec 30, 2024

Changes Overview

This adds a new package, extension-utils, which will coalesce several tiptap utility packages into one package.

  • selection: This extension will "hold" the current selection, even if the editor is blurred, allowing the selection to persist visually
  • trailing-node: This extension will add a "trailing node", an empty node at the end of the document, which will allow for the user to type after some nodes which may be tricky to get the selection to "get around" like a table or image at the end of the document

While also moving a number of extensions into this package:

  • focus
  • gapcursor
  • dropcursor

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Dec 30, 2024

⚠️ No Changeset found

Latest commit: 2e12fdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 2e12fdc
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6772c8be60827c0008a23d94
😎 Deploy Preview https://deploy-preview-5970--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 30, 2024

Open in Stackblitz

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@5970

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@5970

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@5970

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@5970

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@5970

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@5970

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@5970

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@5970

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@5970

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@5970

@tiptap/extension-collaboration-cursor

npm i https://pkg.pr.new/@tiptap/extension-collaboration-cursor@5970

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@5970

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@5970

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@5970

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@5970

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@5970

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@5970

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@5970

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@5970

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@5970

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@5970

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@5970

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@5970

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@5970

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@5970

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@5970

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@5970

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@5970

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@5970

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@5970

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@5970

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@5970

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@5970

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@5970

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@5970

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@5970

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@5970

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@5970

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@5970

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@5970

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@5970

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@5970

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@5970

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@5970

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@5970

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@5970

@tiptap/extension-utils

npm i https://pkg.pr.new/@tiptap/extension-utils@5970

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@5970

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@5970

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@5970

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@5970

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@5970

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@5970

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@5970

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@5970

commit: 2e12fdc

@nperez0111
Copy link
Contributor Author

This follows the same pattern as the #5469 PR where it moves the focus extension into the extension-utils extension and will make the original extension a re-export

Copy link
Member

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdbch bdbch merged commit e5f1342 into next Jan 6, 2025
15 checks passed
@bdbch bdbch deleted the extension-utils branch January 6, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants