Fixed issue where can() returned false when the command was executable

demos/src/Examples/Default/React/index.jsx

@@ -84,48 +84,56 @@ const MenuBar = () => {
         <button
           onClick={() => editor.chain().focus().toggleHeading({ level: 1 }).run()}
           className={editor.isActive('heading', { level: 1 }) ? 'is-active' : ''}
+          disabled={!editor.can().toggleHeading({ level: 1 })}
         >
           H1
         </button>
         <button
           onClick={() => editor.chain().focus().toggleHeading({ level: 2 }).run()}
           className={editor.isActive('heading', { level: 2 }) ? 'is-active' : ''}
+          disabled={!editor.can().toggleHeading({ level: 2 })}
         >
           H2
         </button>
         <button
           onClick={() => editor.chain().focus().toggleHeading({ level: 3 }).run()}
           className={editor.isActive('heading', { level: 3 }) ? 'is-active' : ''}
+          disabled={!editor.can().toggleHeading({ level: 3 })}
         >
           H3
         </button>
         <button
           onClick={() => editor.chain().focus().toggleHeading({ level: 4 }).run()}
           className={editor.isActive('heading', { level: 4 }) ? 'is-active' : ''}
+          disabled={!editor.can().toggleHeading({ level: 4 })}
         >
           H4
         </button>
         <button
           onClick={() => editor.chain().focus().toggleHeading({ level: 5 }).run()}
           className={editor.isActive('heading', { level: 5 }) ? 'is-active' : ''}
+          disabled={!editor.can().toggleHeading({ level: 5 })}
         >
           H5
         </button>
         <button
           onClick={() => editor.chain().focus().toggleHeading({ level: 6 }).run()}
           className={editor.isActive('heading', { level: 6 }) ? 'is-active' : ''}
+          disabled={!editor.can().toggleHeading({ level: 6 })}
         >
           H6
         </button>
         <button
           onClick={() => editor.chain().focus().toggleBulletList().run()}
           className={editor.isActive('bulletList') ? 'is-active' : ''}
+          disabled={!editor.can().toggleBulletList()}
         >
           Bullet list
         </button>
         <button
           onClick={() => editor.chain().focus().toggleOrderedList().run()}
           className={editor.isActive('orderedList') ? 'is-active' : ''}
+          disabled={!editor.can().toggleOrderedList()}
         >
           Ordered list
         </button>

demos/src/Examples/Default/React/index.spec.js

@@ -10,6 +10,28 @@ context('/src/Examples/Default/React/', () => {
     })
   })
 
+  it('Heading, bulletList, and orderedList should be allowed to convert between each other.', () => {
+    cy.get('.tiptap h1').should('exist')
+    cy.get('.tiptap ul').should('not.exist')
+    cy.get('.tiptap ol').should('not.exist')
+    cy.get('button').contains('Bullet list').should('not.be.disabled')
+    cy.get('button').contains('Ordered list').should('not.be.disabled')
+
+    cy.get('button').contains('Bullet list').click()
+    cy.get('.tiptap h1').should('not.exist')
+    cy.get('.tiptap ul').should('exist')
+    cy.get('.tiptap ol').should('not.exist')
+    cy.get('button').contains('H1').should('not.be.disabled')
+    cy.get('button').contains('Ordered list').should('not.be.disabled')
+
+    cy.get('button').contains('Ordered list').click()
+    cy.get('.tiptap h1').should('not.exist')
+    cy.get('.tiptap ul').should('not.exist')
+    cy.get('.tiptap ol').should('exist')
+    cy.get('button').contains('H1').should('not.be.disabled')
+    cy.get('button').contains('Bullet list').should('not.be.disabled')
+  })
+
   it('should apply the paragraph style when the keyboard shortcut is pressed', () => {
     cy.get('.tiptap h1').should('exist')
     cy.get('.tiptap p').should('not.exist')

demos/src/Examples/Transition/Vue/index.spec.js

@@ -1,3 +1,5 @@
+/// <reference types="cypress" />
+
 context('/src/Examples/Transition/Vue/', () => {
   beforeEach(() => {
     cy.visit('/src/Examples/Transition/Vue/')

packages/core/src/CommandManager.ts

@@ -101,7 +101,7 @@ export class CommandManager {
 
   public createCan(startTr?: Transaction): CanCommands {
     const { rawCommands, state } = this
-    const dispatch = false
+    const dispatch = true
     const tr = startTr || state.tr
     const props = this.buildProps(tr, dispatch)
     const formattedCommands = Object.fromEntries(

packages/core/src/commands/clearNodes.ts

@@ -42,7 +42,9 @@ export const clearNodes: RawCommands['clearNodes'] = () => ({ state, tr, dispatc
       if (node.type.isTextblock) {
         const { defaultType } = $mappedFrom.parent.contentMatchAt($mappedFrom.index())
 
-        tr.setNodeMarkup(nodeRange.start, defaultType)
+        if (defaultType && defaultType.isTextblock) {
+          tr.setNodeMarkup(nodeRange.start, defaultType)
+        }
       }
 
       if (targetLiftDepth || targetLiftDepth === 0) {

tests/cypress/integration/core/can.spec.ts

@@ -168,7 +168,7 @@ describe('can', () => {
     expect(canSetMarkToBold).to.eq(true)
   })
 
-  it('builds and passes down an undefined dispatch for nested "can" chain', () => {
+  it('builds and passes down a function dispatch for nested "can" chain', () => {
     const editor = new Editor({
       extensions: [Document, Paragraph, Text, History],
     })
@@ -191,8 +191,8 @@ describe('can', () => {
       .run()
 
     // eslint-disable-next-line no-unused-expressions
-    expect(capturedOuterDispatch).to.be.undefined
+    expect(capturedOuterDispatch).to.be.not.undefined
     // eslint-disable-next-line no-unused-expressions
-    expect(capturedInnerDispatch).to.be.undefined
+    expect(capturedInnerDispatch).to.be.not.undefined
   })
 })