Skip to content

fix: keep inline combobox point ref live#4940

Merged
zbeyens merged 4 commits intomainfrom
codex/4778-inline-combobox-point-ref
Apr 1, 2026
Merged

fix: keep inline combobox point ref live#4940
zbeyens merged 4 commits intomainfrom
codex/4778-inline-combobox-point-ref

Conversation

@zbeyens
Copy link
Copy Markdown
Member

@zbeyens zbeyens commented Apr 1, 2026

🐛 Fixes #4778
🟢 95-100% confidence

Phase 🧪 Tests 🌐 Browser
Reproduced 🔴 ➖ N/A
Verified 🟢 ➖ N/A

✅ Outcome

  • Fixed apps/www/src/registry/ui/inline-combobox.tsx to keep the live PointRef itself, then read pointRef.current only when canceling input.
  • Added regression coverage in apps/www/src/registry/ui/inline-combobox.spec.tsx that fails on the stale snapshot bug and passes with the fix.
  • Updated the registry changelog in content/components/changelog.mdx and regenerated registry output, including apps/www/public/r/inline-combobox.json and apps/www/public/r/components-changelog-docs.json.

⚠️ Caveat

  • Browser check skipped. This is a ref-bookkeeping bug, not a visual/UI rendering change.
  • Local repo gate was briefly blocked by mixed .bun and .pnpm React installs; pnpm run reinstall cleared that corruption and pnpm check passes now.

🏗️ Design

  • Chosen seam: fix the component’s ref ownership in apps/www/src/registry/ui/inline-combobox.tsx.
  • Why not quick patch: any version that still copies pointRef.current just rebrands the same stale snapshot bug.
  • Why not broader change: the editor PointRef API is already correct; the misuse was local.

🧪 Verified

  • bun test apps/www/src/registry/ui/inline-combobox.spec.tsx
  • pnpm install
  • pnpm --filter www build:registry
  • pnpm --filter www typecheck
  • pnpm lint:fix
  • pnpm check

@zbeyens zbeyens requested a review from a team April 1, 2026 20:54
@codesandbox
Copy link
Copy Markdown

codesandbox bot commented Apr 1, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 1, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
plate Ready Ready Preview, Comment Apr 1, 2026 10:37pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 1, 2026

⚠️ No Changeset found

Latest commit: 1fbb335

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Apr 1, 2026
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Apr 1, 2026
@zbeyens zbeyens merged commit 0173703 into main Apr 1, 2026
3 of 4 checks passed
@zbeyens zbeyens deleted the codex/4778-inline-combobox-point-ref branch April 1, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Bugfix & documentation PR plugin:combobox regression size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant code in inline-combobox.tsx

1 participant