fix: keep inline combobox point ref live#4940
Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
…acy values" This reverts commit 5a11385.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fixes #4778
🟢 95-100% confidence
✅ Outcome
apps/www/src/registry/ui/inline-combobox.tsxto keep the livePointRefitself, then readpointRef.currentonly when canceling input.apps/www/src/registry/ui/inline-combobox.spec.tsxthat fails on the stale snapshot bug and passes with the fix.content/components/changelog.mdxand regenerated registry output, includingapps/www/public/r/inline-combobox.jsonandapps/www/public/r/components-changelog-docs.json..bunand.pnpmReact installs;pnpm run reinstallcleared that corruption andpnpm checkpasses now.🏗️ Design
apps/www/src/registry/ui/inline-combobox.tsx.pointRef.currentjust rebrands the same stale snapshot bug.PointRefAPI is already correct; the misuse was local.🧪 Verified
bun test apps/www/src/registry/ui/inline-combobox.spec.tsxpnpm installpnpm --filter www build:registrypnpm --filter www typecheckpnpm lint:fixpnpm check