Remove untested typeclass elaboration#2434
Conversation
eeb9605 to
da21f9a
Compare
|
@ranjitjhala, @nikivazou, there is no test depending on the code in Bare.Elaborate which this PR is removing. Section 3.2 of Verifying Replicated Data Types with Typeclass Refinements Do you have any tests that rehearse this code? My first attempt to produce a test faced a crash. |
|
@nikivazou -- can you help with this? I am unfamiliar with the code? Is it "dead" code or no? |
|
I agree with @facundominguez btw that we should either add tests that exercise this functionality, or, if there is no such code because the type-class stuff has not been kept compatible, then we should just remove or comment it out... |
|
Correct! There are the test of the artifacts of the paper, I guess, not all of them are part of the test suite. Will try to find them and let you know. |
|
Here are all the benchmarks from the paper. Probably the ones from |
|
Thanks!!!! I think it does not make sense to move all these in the test repo of Liquid Haskell.. |
|
I just noticed some related tests that used to run on GHCs earlier than 9. liquidhaskell/tests/tests.cabal Line 2601 in 92c0a7e |
Ah, maybe we should just update those tests to run with the newer GHC? |
No description provided.