Open
Conversation
will no longer have any effect.
functions in PLE
remove redundant code in evalApp
Collaborator
|
@nikivazou is this something worth pursuing to completion now the the interpreter has been merged? I lack some context to be sure, but two things seem to be happening in this PR that look worth finishing: Firstly, code duplication in PLE and the interpreter is factored out. Secondly, there is an attempt to simplify the interpreter by discarding the Trie that PLE uses, and instead going with a smaller procedure (maybe you can give an overview of the differences). |
Member
Author
|
Exactly! There is the refactoring and code is much simpler. But this interpreter is not strong enough for @michaelborkowski 's case study to pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.