-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmake version file #1493
Add cmake version file #1493
Conversation
cmake/OpenJPEGConfigVersion.cmake.in is copied from cmake sources, covered by 3-clause BSD license. They have no copyright header and cmake documentation says "they can be used as starting point to create more sophisticated custom ConfigVersion.cmake files"[1], so not sure if we should bother. [1] https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html |
@mayeut does that look good to you ? |
One more doubt. I used |
it is not |
I believe we should just remove support for CMake < 3.0. Newer CMake versions are actually going to remove support for CMake < 3.5 soon. That way we could remove cmake/OpenJPEGConfigVersion.cmake.in |
If dropping support for old cmake is an option, I would be really happy with that. |
would you be interested in tackling that?
indeed |
I will try to find some time this week to make PR removing support for cmake < 3.5. |
Rebased. |
Add the missing cmake version file, so that software using the library can check for version compatibility.