Moved most test files to be adjacent to the files they test #1967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think the conflicts exist because I've removed the |
FrenjaminBanklin
changed the base branch from
dev/27-pyrite
to
dev/28-jadeite
Contributor
|
Closing this in favor of #1984, which was branched from a more recent commit and thus has no merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it turns out the file paths work out for most of these by default when the test files are moved because the layout of the
__tests__folder matches that of thesrcfolder in the same directory. I moved everything except for some tests inobojobo-document-json-parserandobojobo-document-json-parserbecause they're a little different. The tests work and pass, but I have not exhaustively scrutinized them.