Attempts to phrase the debian/watch paragraph more future proof #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By acknowledging that there are alternatives, mentioning the current modern one (git-buildpackage with debian/upstream/metadata) and allowing future standards to be considered without fear. Fixes ubuntu#328
CarlosNihelton
requested review from
MylesJP,
cpaelzer,
didrocks,
joalif,
pushkarnk,
setharnold and
slyon
as code owners
cpaelzer
reviewed
Jan 6, 2026
| TODO-A: - debian/watch is present and works | ||
| TODO-B: - debian/watch is not present, instead it has TBD | ||
| TODO-C: - debian/watch is not present because it is a native package | ||
| RULE: - The package uses a debian/watch or debian/upstream/metadata files |
Collaborator
There was a problem hiding this comment.
Suggested change
| RULE: - The package uses a debian/watch or debian/upstream/metadata files | |
| RULE: - The package uses a debian/watch or debian/upstream/metadata file |
cpaelzer
reviewed
Jan 6, 2026
| TODO-B: - debian/watch is not present, instead it has TBD | ||
| TODO-C: - debian/watch is not present because it is a native package | ||
| RULE: - The package uses a debian/watch or debian/upstream/metadata files | ||
| RULE: whenever possible. The second options is the current modern alternative |
Collaborator
There was a problem hiding this comment.
Suggested change
| RULE: whenever possible. The second options is the current modern alternative | |
| RULE: whenever possible. The second option is the alternative |
Collaborator
There was a problem hiding this comment.
let us not get into a fight pro/con gbp :-)
cpaelzer
reviewed
Jan 6, 2026
| RULE: For clarity the TODOs below refer as "upstream watch file" to any | ||
| RULE: solution similar to the alternatives above which must be present in the | ||
| RULE: package so tools can detect and fetch new upstream releases. | ||
| TODO-A: - upstream watch file is present and works |
Collaborator
There was a problem hiding this comment.
How about
Suggested change
| TODO-A: - upstream watch file is present and works | |
| TODO-A: - A mechanism to detect and fetch new upstream versions present and works (watch / metadata) |
And the same "mechanism to detect and fetch new upstream versions" for each of the others too
This is now strictly needed, just a suggestion - feel free to reject
Collaborator
|
Thank you for your work @CarlosNihelton - mostly 99% +1, some suggestions |
joalif
approved these changes
Jan 7, 2026
Collaborator
joalif
left a comment
joalif
left a comment
There was a problem hiding this comment.
Thanks for the pr, +1 once Christian's comments are resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here's a humble attempt to tackle #328 by making the MIR reporters template more generic and future proof in regards to the
debian/watchfile being present or not. The motivation is better explained in the motivating issue.Related issue
debian/watchwithout alternatives is misleading #328Checklist