feat(internal/cachekey): add cache path/key construction package#177
Open
justinwon777 wants to merge 1 commit into
Open
feat(internal/cachekey): add cache path/key construction package#177justinwon777 wants to merge 1 commit into
justinwon777 wants to merge 1 commit into
Conversation
Adds internal/cachekey with the cache-path builders (ToShortRemote, GetGraphByTreeHash, GetTreehashCachePath, GetComparedTargetsCachePath) that today live in core/common/utils.go. This is purely additive: no existing callers are migrated and core/common is untouched, so this package is currently unused. A follow-up PR will switch controller and orchestrator over to it and remove the duplicated code from core/common. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sywhang
reviewed
Jul 10, 2026
|
|
||
| // ToShortRemote returns the short remote name given a git ssh remote string. | ||
| // For example, "git@github:uber/tango" will return "uber/tango". | ||
| func ToShortRemote(remote string) string { |
Contributor
There was a problem hiding this comment.
this conflicts with some of the changes I'm trying to make in #164.... Can we wait till that one is merged, or at least propagate the changes here?
Contributor
Author
There was a problem hiding this comment.
yeah I'll wait for yours to merge
Contributor
Author
There was a problem hiding this comment.
Saw that PR closed, so you're not making changes to these then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds internal/cachekey with the cache-path builders (ToShortRemote, GetGraphByTreeHash, GetTreehashCachePath, GetComparedTargetsCachePath) that today live in core/common/utils.go. A follow-up PR will switch controller and orchestrator to use this package.
Test Plan
unit tests
Issue