Playwright updates for xdmod-supremm #2027
Conversation
These minor changes were found while getting the playwright tests working for xdmod-supremm.
ryanrath
added
maintenance / code quality
ryanrath
requested review from
eiffel777,
jpwhite4,
rvtovar,
aaronweeden and
connersaeli
tests/playwright/lib/base.page.ts
Outdated
| @@ -10,6 +11,9 @@ export class BasePage { | |||
| this.page = page; | |||
| this.maskSelector = '.ext-el-mask-msg'; | |||
| this.mask = page.locator(this.maskSelector); | |||
| if (baseUrl == undefined || baseUrl.length === 0) { | |||
There was a problem hiding this comment.
The type hinting says that baseUrl is a string - doesn't that mean it can't be undefined? I'm not 110% sure how the typescript type hinting functions
There was a problem hiding this comment.
looks like you could never make baseUrl undefined or null so that check is done by the compiler and you don't need to do it in code.
There was a problem hiding this comment.
Yup, I think I put this in as a precaution while developing. It'll be removed.
| @@ -80,7 +80,6 @@ class MetricExplorer extends BasePage{ | |||
| await this.page.click(this.newChart.modalDialog.ok()); | |||
| await expect(this.page.locator(this.newChart.modalDialog.box)).toBeHidden(); | |||
| await expect(this.page.locator(this.newChart.modalDialog.noDataMessage)).toBeVisible(); | |||
| await expect(this.page.locator(this.mask)).toBeHidden(); | |||
There was a problem hiding this comment.
How come you removed this check?
There was a problem hiding this comment.
So I'm pretty sure I removed it because I misread it to be await this.page.locator(this.mask).isHidden(); which doesn't do anything. But it ends up that having it or not having it doesn't seem to affect whether or not tests that call this function pass.
Description
Motivation and Context
These minor changes were found while getting the playwright tests working for xdmod-supremm.
Tests performed
Checklist: