Update circleci config #2022
Open
Update circleci config #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the code coverage installation / setup step up so that we get more info in the coverage data. Added an `or` switch to the conditions under which code coverage data is generated so that we can easily trigger coverage generation outside of the nightly build.
ryanrath
force-pushed
the
update-circleci-config
branch
from
dd764eb to
ebf36c4
Compare
jpwhite4
reviewed
Apr 7, 2025
| @@ -500,7 +500,7 @@ echo ${arg_r} | |||
| echo | |||
| echo $PROCESS_FILE_INSTALL_PATH | |||
|
|
|||
| ~/bin/services restart | |||
| #~/bin/services restart | |||
There was a problem hiding this comment.
Please remove this line rather than adding commented out code.
jpwhite4
reviewed
Apr 7, 2025
| condition: | ||
| or: | ||
| - and: | ||
| - equal: [ scheduled_pipeline, << pipeline.trigger_source >> ] |
There was a problem hiding this comment.
Please can you add some documentation to explain how to trigger code coverage capture (this could be a readme or just comments in this file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved the code coverage installation / setup step up so that we get more
info in the coverage data.
Added an
orswitch to the conditions under which code coverage data isgenerated so that we can easily trigger coverage generation outside of
the nightly build.
Motivation and Context
Tests performed
Checklist: