-
Notifications
You must be signed in to change notification settings - Fork 69
removed normalized_avg_processors and created documentation on how to add it back #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…on how to re add it.
When i was orginally removing normailzied_avg_processors i accidentally modified the shape of has_data_access.json which caused the component test to fail. After seeing that i went back in and used jq to fix the json to be in the shape that it is supposed to, Component Testing passes. |
Co-authored-by: Joe White <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also suggest adding a Configuration File Changes
section to the Upgrade Guide (docs/upgrade.md
) under the Additional 11.5.0 Upgrade Notes
section and mention that the statistic is being removed with a link to docs/howto-normalized-avg-processors.md
to read about how to restore it if desired.
There will also need to be a PR in to xdmod-xsede since normalized_avg_processors
is also defined there.
Co-authored-by: Aaron Weeden <[email protected]>
Co-authored-by: Aaron Weeden <[email protected]>
Co-authored-by: Aaron Weeden <[email protected]>
Co-authored-by: Aaron Weeden <[email protected]>
Description
removed normalized_avg_processors from configuration/datawarehouse.d/ref/ gateways-statsitics.json and job-statistics.json, deleted jobs-norm-avg-proc-time.sql and jobs-norm-avg-proc-agg.sql from configuration/datawarehouse.d/include.
Then created howto-normalized-avg-processor.md on how to re add the statistic.
Motivation and Context
The statistic did not have much use and was a 100% correct because of the sql so it was removed with a documenation added to re add it if someone was interested in that statistic.
Tests performed
Re ran all the regression test on a aarch64 and x86_64 system.
Checklist: