Skip to content

removed normalized_avg_processors and created documentation on how to add it back #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

rvtovar
Copy link
Contributor

@rvtovar rvtovar commented Feb 11, 2025

Description

removed normalized_avg_processors from configuration/datawarehouse.d/ref/ gateways-statsitics.json and job-statistics.json, deleted jobs-norm-avg-proc-time.sql and jobs-norm-avg-proc-agg.sql from configuration/datawarehouse.d/include.

Then created howto-normalized-avg-processor.md on how to re add the statistic.

Motivation and Context

The statistic did not have much use and was a 100% correct because of the sql so it was removed with a documenation added to re add it if someone was interested in that statistic.

Tests performed

Re ran all the regression test on a aarch64 and x86_64 system.

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@rvtovar rvtovar added this to the 11.5.0 milestone Feb 11, 2025
@rvtovar rvtovar requested a review from jpwhite4 February 11, 2025 16:44
@rvtovar rvtovar self-assigned this Feb 11, 2025
@rvtovar
Copy link
Contributor Author

rvtovar commented Feb 12, 2025

When i was orginally removing normailzied_avg_processors i accidentally modified the shape of has_data_access.json which caused the component test to fail. After seeing that i went back in and used jq to fix the json to be in the shape that it is supposed to, Component Testing passes.

@rvtovar rvtovar marked this pull request as ready for review February 18, 2025 15:38
eiffel777
eiffel777 previously approved these changes Feb 19, 2025
Copy link
Contributor

@aaronweeden aaronweeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also suggest adding a Configuration File Changes section to the Upgrade Guide (docs/upgrade.md) under the Additional 11.5.0 Upgrade Notes section and mention that the statistic is being removed with a link to docs/howto-normalized-avg-processors.md to read about how to restore it if desired.

There will also need to be a PR in to xdmod-xsede since normalized_avg_processors is also defined there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants