Fix issues with scope updates #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves the following two issues: - when all splits are out of scope, we update the lowerbound to reflect that the subproblem is out of scope (the prior fix to the code's logic in this case was incomplete) - when we visit tasks that have already been created in the graph, we make sure to still update the scope and check for information given the new scope. Our PR review will need to confirm that this does not lead to excessive calls to the store_children logic (i.e. when the scope updates but upperscope remains the same).
ilias-karimalis
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the following two issues:
The current version of the solution leads to calls to the store_children logic that are not strictly necessary (i.e. when the scope updates but upperscope remains the same). It is not immediately clear whether this will be a benefit or detriment to runtime; we may want to make an issue to investigate this.