Skip to content

Conversation

j-crawford
Copy link

got the colors fixed, had to do it on 2.6.1 since master isn't stable

@j-crawford
Copy link
Author

j-crawford commented Apr 19, 2019

@ChristianMurphy it was building without errors here, should I try to do a pull request to 2.6.1 instead of master?

@j-crawford
Copy link
Author

j-crawford commented Apr 19, 2019

we found that the error keeping it from building is in the @notTreadSafe is due to it not being supported in org.apache.httpcomponents:httpcore past version 4.2.5 there may be other bugs but that's one that we found.

@ChristianMurphy
Copy link
Member

@j-crawford keep the PR to master, a resolution for @NotThreadSafe is in progress at #162

…iables to make it easier to change them and have them still be in sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants