Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global_dedicated_key: A key can be global or dedicated, not both #87

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dlms_cosem/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class DlmsConnection:
# it hits the maximum value the global key needs to be exchanged.
use_dedicated_ciphering: bool = attr.ib(default=False)
# Dedicated key will be generated on each association
global_dedicated_key: Optional[bytes] = attr.ib(default=None)
global_dedicated_key: Optional[bytes] = attr.ib(default=None) # FIXME: a key can be global or dedicated, not both
# the dedicated invocation_counter will be reset on each new dedicated_key.
dedicated_invocation_counter: int = attr.ib(init=False, default=0)

Expand Down