Skip to content

Fix chart.js-v4 invalid engine warning #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

jmaddington
Copy link

@jmaddington jmaddington commented Mar 31, 2025

Summary

This PR resolves three dependency warning issues:

Test plan

  • Verify that the invalid engine warning is gone during installation
  • Verify that chartjs-adapter-moment peer dependency warnings are gone
  • GitHub Actions should run tests to ensure chart rendering still works properly

🤖 Generated with Claude Code

andrii-ivanov and others added 21 commits February 18, 2025 15:42
This commit integrates a chart template storage and retrieval system, which was previously unavailable due to lack of FOSS implementations. Key additions include:

- SQLite database integration for persistent storage of chart templates
- New API endpoints for chart template creation and retrieval
- Database schema with automatic cleanup of expired templates
- Template overrides allowing customization of stored templates via URL parameters
- Docker volume support for persistent database storage
- Additional documentation for the template feature
- Test suite for template creation and retrieval functionality

The template system allows users to:
1. Store complex chart configurations as reusable templates
2. Retrieve and render templates with a simple ID
3. Dynamically override template parameters (title, labels, etc.)
4. Set expiration dates for temporary templates

This significantly enhances the utility of QuickChart by enabling persistent chart configurations without requiring long URLs for each chart instance.
- Added json-schema ^0.4.0 to both resolutions and overrides in package.json
- Modified GitHub Actions workflow to run tests on any branch push
- Added flat ^5.0.1 to both resolutions and overrides
- Added crypto-js ^4.2.0 to both resolutions and overrides
- Resolves Dependabot alert #11
- Eliminates critical security vulnerabilities

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
- Added resolutions for known high severity vulnerabilities:
  - cross-spawn ^6.0.6 (ReDoS vulnerability)
  - axios ^1.8.2 (SSRF and Credential Leakage)
  - minimatch ^3.0.5 (ReDoS vulnerability)
  - ws ^7.5.10 (DoS vulnerability)
  - nth-check ^2.0.1 (ReDoS vulnerability)
  - body-parser ^1.20.3 (DoS vulnerability)
  - path-to-regexp ^0.1.12 (ReDoS vulnerability)

- Reduced high severity vulnerabilities from 10 to 1
- Remaining high severity vulnerability in lodash.pick has no patch available

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not encoding Japanese/Chinese correctly Title in sparkline style takes too much space
2 participants