-
-
Notifications
You must be signed in to change notification settings - Fork 246
Fix chart.js-v4 invalid engine warning #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmaddington
wants to merge
21
commits into
typpo:master
Choose a base branch
from
jmaddington:security/7/invalid-engine
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit integrates a chart template storage and retrieval system, which was previously unavailable due to lack of FOSS implementations. Key additions include: - SQLite database integration for persistent storage of chart templates - New API endpoints for chart template creation and retrieval - Database schema with automatic cleanup of expired templates - Template overrides allowing customization of stored templates via URL parameters - Docker volume support for persistent database storage - Additional documentation for the template feature - Test suite for template creation and retrieval functionality The template system allows users to: 1. Store complex chart configurations as reusable templates 2. Retrieve and render templates with a simple ID 3. Dynamically override template parameters (title, labels, etc.) 4. Set expiration dates for temporary templates This significantly enhances the utility of QuickChart by enabling persistent chart configurations without requiring long URLs for each chart instance.
- Added json-schema ^0.4.0 to both resolutions and overrides in package.json - Modified GitHub Actions workflow to run tests on any branch push
- Added flat ^5.0.1 to both resolutions and overrides - Added crypto-js ^4.2.0 to both resolutions and overrides - Resolves Dependabot alert #11 - Eliminates critical security vulnerabilities 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Added resolutions for known high severity vulnerabilities: - cross-spawn ^6.0.6 (ReDoS vulnerability) - axios ^1.8.2 (SSRF and Credential Leakage) - minimatch ^3.0.5 (ReDoS vulnerability) - ws ^7.5.10 (DoS vulnerability) - nth-check ^2.0.1 (ReDoS vulnerability) - body-parser ^1.20.3 (DoS vulnerability) - path-to-regexp ^0.1.12 (ReDoS vulnerability) - Reduced high severity vulnerabilities from 10 to 1 - Remaining high severity vulnerability in lodash.pick has no patch available 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…lities' into fix-security
…s' into fix-security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves three dependency warning issues:
Test plan
🤖 Generated with Claude Code