Skip to content

refactor(api_call): improve node selection with shuffling #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025

Conversation

tharropoulos
Copy link
Contributor

Change Summary

  • Add requestNumber parameter to getNode() method for request tracking
  • Add detailed debug logging throughout node selection process
  • Fix node selection loop to properly iterate through all available nodes
  • Improve fallback logic when no healthy nodes are found
  • Replace direct node access with candidate node pattern for better readability

PR Checklist

  1. I have read and signed the Contributor License Agreement.

- Add `requestNumber` parameter to `getNode()` method for request tracking
- Add detailed debug logging throughout node selection process
- Fix node selection loop to properly iterate through all available nodes
- Improve fallback logic when no healthy nodes are found
- Replace direct node access with candidate node pattern for better readability
@jasonbosco jasonbosco merged commit 89bace5 into typesense:master Jun 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants