Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Rename PresetSchema property id to name #191

Merged
merged 1 commit into from
Jan 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
FIX Rename PresetSchema property id to name
This is only for the typings to match structure of real api return. Library already works since the data is not accessed by name.
bfritscher committed Jan 23, 2024
commit 035e460292af64284c2e68c20cfd384c57011ce2
2 changes: 1 addition & 1 deletion dist/typesense.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions lib/Typesense/Preset.d.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import ApiCall from "./ApiCall";
import { PresetCreateSchema } from "./Presets";
export interface PresetSchema extends PresetCreateSchema {
id: string;
name: string;
}
export interface PresetDeleteSchema {
id: string;
name: string;
}
export default class Preset {
private presetId;
4 changes: 2 additions & 2 deletions src/Typesense/Preset.ts
Original file line number Diff line number Diff line change
@@ -2,11 +2,11 @@ import ApiCall from "./ApiCall";
import Presets, { PresetCreateSchema } from "./Presets";

export interface PresetSchema extends PresetCreateSchema {
id: string;
name: string;
}

export interface PresetDeleteSchema {
id: string;
name: string;
}

export default class Preset {