fix(eslint-plugin): [no-unnecessary-type-assertion] handle literal types #10523

mdm317 · 2024-12-19T16:00:23Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-unnecessary-type-assertion] False report with an 'as' assertion #10257
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Add case when cast type is a template literal or a union type that is string-like.

typescript-eslint · 2024-12-19T16:00:27Z

Thanks for the PR, @mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-12-19T16:00:47Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`4c45f10`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/677634b367d5db00088dad84
😎 Deploy Preview	https://deploy-preview-10523--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-12-19T16:11:32Z

View your CI Pipeline Execution ↗ for commit 4c45f10.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	5s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️ Nx Cloud last updated this comment at 2025-01-03 01:57:55 UTC

codecov · 2024-12-19T16:33:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (4dbf48b) to head (4c45f10).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10523   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files         446      446           
  Lines       15502    15504    +2     
  Branches     4516     4517    +1     
=======================================
+ Hits        13472    13474    +2     
  Misses       1675     1675           
  Partials      355      355

Flag	Coverage Δ
unittest	`86.90% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...-plugin/src/rules/no-unnecessary-type-assertion.ts	`98.00% <100.00%> (+0.04%)`	⬆️

JoshuaKGoldberg

LGTM! Just requesting changes on naming and removing the noFormat. Thanks!

JoshuaKGoldberg · 2024-12-21T15:02:26Z

packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts

@@ -358,6 +358,16 @@ if (Math.random()) {
 x!;
      `,
    },
+    "let a = (Date.now() % 2 ? 'a' : 'b') as 'a' | 'b';",
+    noFormat`


[Style] The added doesn't involve formatting/layout nuance, so there's no need to noFormat in them:

Suggested change

noFormat`

`

JoshuaKGoldberg · 2024-12-21T15:04:11Z

packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts

-        const wouldSameTypeBeInferred = castType.isLiteral()
-          ? isImplicitlyNarrowedConstDeclaration(node)
-          : !isConstAssertion(node.typeAnnotation);
+        const isCastTypeTemplateLiteral =


[Docs] #10472

Suggested change

const isCastTypeTemplateLiteral =

const isAssertionTypeTemplateLiteral =

JoshuaKGoldberg

🪨

ronami

Looking great! Just requesting minor changes around testing 🏆

Edit: I'm not sure if it's too fringe, but I did see one regression with the readonly modifier (main branch playground link, deploy preview playground link).

ronami · 2025-01-02T18:59:40Z

packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts

+
+        const wouldSameTypeBeInferred =
+          castType.isLiteral() ||
+          isAssertionTypeTemplateLiteral ||


[Testing]: No tests fail if this is omitted (isAssertionTypeTemplateLiteral ||), let's simplify or add a test case?

fix : add case when cast type is a template literal or a union type.

9b4de1f

mdm317 marked this pull request as draft December 19, 2024 16:00

mdm317 marked this pull request as ready for review December 20, 2024 11:53

JoshuaKGoldberg requested changes Dec 30, 2024

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Dec 30, 2024

mdm317 and others added 3 commits January 1, 2025 14:33

avoid using cast the word cast

0b88ee2

delete useless noFormat

e33c712

Merge branch 'main' into fix/10275-no-unnecessary-type-assertion

4c45f10

mdm317 requested a review from JoshuaKGoldberg January 2, 2025 13:46

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 2, 2025

JoshuaKGoldberg approved these changes Jan 2, 2025

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 2, 2025

ronami requested changes Jan 2, 2025

View reviewed changes

JoshuaKGoldberg added awaiting response Issues waiting for a reply from the OP or another party and removed 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Jan 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [no-unnecessary-type-assertion] handle literal types #10523

fix(eslint-plugin): [no-unnecessary-type-assertion] handle literal types #10523

mdm317 commented Dec 19, 2024 •

edited by JoshuaKGoldberg

Loading

typescript-eslint bot commented Dec 19, 2024

netlify bot commented Dec 19, 2024 •

edited

Loading

nx-cloud bot commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg Dec 21, 2024

JoshuaKGoldberg Dec 21, 2024

JoshuaKGoldberg left a comment

ronami left a comment •

edited

Loading

ronami Jan 2, 2025

	const isCastTypeTemplateLiteral =
	const isAssertionTypeTemplateLiteral =

fix(eslint-plugin): [no-unnecessary-type-assertion] handle literal types #10523

Are you sure you want to change the base?

fix(eslint-plugin): [no-unnecessary-type-assertion] handle literal types #10523

Conversation

mdm317 commented Dec 19, 2024 • edited by JoshuaKGoldberg Loading

PR Checklist

Overview

typescript-eslint bot commented Dec 19, 2024

netlify bot commented Dec 19, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Dec 19, 2024 • edited Loading

codecov bot commented Dec 19, 2024 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg Dec 21, 2024

Choose a reason for hiding this comment

JoshuaKGoldberg Dec 21, 2024

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

ronami left a comment • edited Loading

Choose a reason for hiding this comment

ronami Jan 2, 2025

Choose a reason for hiding this comment

mdm317 commented Dec 19, 2024 •

edited by JoshuaKGoldberg

Loading

netlify bot commented Dec 19, 2024 •

edited

Loading

nx-cloud bot commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading

ronami left a comment •

edited

Loading