Increase Fidelity of the sbt.testing.Framework Implementation #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 16, 2025
dubinsky
force-pushed
the
increase-fidelity-of-the-sbt-testing-framework-implementation
branch
from
05bd678 to
7ce3e5f
Compare
dubinsky
force-pushed
the
increase-fidelity-of-the-sbt-testing-framework-implementation
branch
from
7ce3e5f to
da9cb92
Compare
|
@satorg any thoughts? |
…dcardSelector`s, filter properties to run by matching their names against the `Selector`s; - added a test that actually runs ScalaCheck via the `SBT Test Interface` and demonstrates the (now correct) treatment of the `Selector`s; - test also demonstrates two unfixable infidelities in the treatment of the nested properties; - thankfully, ScalaCheck's implementation of `sbt.testing.Framework` is, unlike in some other test frameworks, shared between the platforms (JVM, Scala.js, Scala Native), so the fixes do not have to be replicated for each platform, but: - the test needs to supply a `testClassLoader: ClassLoader` parameter when calling `sbt.testing.Framework.runner()`; on platforms other than JVM, `getClass.getClassLoader` is not available, so `Platform.getClassLoader: ClassLoader` method was added to every `Platform`; on platforms other than the JVM, it returns `null`, which is fine since on those platforms `sbt.testing.Framework.runner()` ignores the `testClassLoader` parameter anyway. fixes typelevel#1105
dubinsky
force-pushed
the
increase-fidelity-of-the-sbt-testing-framework-implementation
branch
from
da9cb92 to
4a468a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selectors supplied include onlyTestSelectors andTestWildcardSelectors, filter properties to run by matching their names against theSelectors;SBT Test Interfaceand demonstrates the (now correct) treatment of theSelectors;sbt.testing.Frameworkis, unlike in some other test frameworks, shared between the platforms (JVM, Scala.js, Scala Native), so the fixes do not have to be replicated for each platform, but:testClassLoader: ClassLoaderparameter when callingsbt.testing.Framework.runner(); on platforms other than JVM,getClass.getClassLoaderis not available, soPlatform.getClassLoader: ClassLoadermethod was added to everyPlatform; on platforms other than JVM, it returnsnull- which is fine, since on those platformssbt.testing.Framework.runner()ignores thetestClassLoaderparameter anyway.fixes #1105