Add continueOnError option to WorkflowStep #811
Conversation
|
I bumped the tlBaseVersion because the extra param is not bincompatible. Not sure if there is a way to avoid this? I could add the default as false and only add the |
There was a problem hiding this comment.
Thanks for the PR! Sorry it took me a while to circle back for review.
The good news is that it is possible to make these changes bincompatibly. You can't change existing method signatures, but you can deprecate them and add new method signatures.
Sometimes, MiMa doesn't recognize internal private implementations, so you may need to add filters for those.
| renderedWorkingDirectory: String, | ||
| renderedContinueOnError: String) = |
There was a problem hiding this comment.
To fix bincompat, add a deprecated overload of this method with the old signature that passes an empty string to renderedContinueOnError
| timeoutMinutes: Option[Int] = None, | ||
| workingDirectory: Option[String] = None): Run = | ||
| Impl(commands, id, name, cond, env, params, timeoutMinutes, workingDirectory) | ||
| workingDirectory: Option[String] = None, | ||
| continueOnError: Boolean = false): Run = |
There was a problem hiding this comment.
Same thing here: unfortunately, adding a default parameter (= false) will not fix bincompat. However, adding a deprecated overload with the old signature, that passes continueOnError = false to the new overload will work.
hugo-vrijswijk
force-pushed
the
continue-on-error
branch
from
4f63f48 to
46e126a
Compare
It should be all green now. I've had to remove the default parameters from the bincompatible deprecated methods, or calling it would cause confusion. I've had to add internal filters for private case classes, which worked fine. |
No description provided.