-
Notifications
You must be signed in to change notification settings - Fork 50
Tweak the publication condition to prevent publishing from forked repos #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I was just thinking again about adding a dedicated SBT setting for the fork condition. Maybe introducing |
I think it is a good idea not to publish from forks by default, but I can envision situations where users legitimately would want to do so, so I don't think it should be disabled without a way to re-enable it. A dedicated sbt setting seems reasonable to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is a really good change. Sorry it took me so long to review. I have just a couple nitpicks.
One might argue that users can use
githubWorkflowPublishCond
to prevent publishing from forked repos. Sure, but I’m confident this condition should be the default. Adding it manually to the build of dozens of projects isn’t exactly ideal, either.This is basically the same as what we did in #720, but adding the same SBT setting again just feels a bit extra to me 🤷🏻