Add hrishabhxcode contributor component#37
Add hrishabhxcode contributor component#37hrishabhxcode wants to merge 3 commits intotypelevel:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new interactive contributor component for the hrishabhxcode handle and registers it in the contributors list so it appears in the app.
Changes:
- Introduces
hrishabhxcodecontributor UI with formula generation, copy-to-clipboard, and history. - Appends
hrishabhxcodeto theallContributorsNonEmptyList.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/scala/gsoc/contributors/hrishabhxcode.scala | New contributor component implementation (formula generator + clipboard + history). |
| src/main/scala/gsoc/contributors/all.scala | Registers the new contributor in the global contributor list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def copyToClipboard(text: String): IO[Unit] = | ||
| IO.delay(dom.window.navigator.clipboard.writeText(text)) |
There was a problem hiding this comment.
copyToClipboard is typed as IO[Unit], but navigator.clipboard.writeText returns a JS Promise in Scala.js. IO.delay(...) will therefore produce an IO[js.Promise[Unit]] (and won’t sequence/fail the promise), which should not compile and won’t behave as intended. Convert the promise into IO[Unit] (e.g., use the cats-effect Promise interop and .void) and consider handling rejection so a clipboard permission failure doesn’t fail the click handler.
|
Thank you for agreeing to the Typelevel GSoC AI Policy, in which you committed to never use AI to generate descriptions for PRs. Your PR description was generated by Copilot, in violation of our policy. Therefore, I will close your PR at this time. |
No description provided.