Add contributor arnavsharma990 with interactive Tic-Tac-Toe component#34
Add contributor arnavsharma990 with interactive Tic-Tac-Toe component#34arnavsharma990 wants to merge 1 commit intotypelevel:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new contributor component for arnavsharma990, featuring an interactive Tic-Tac-Toe mini-game built with Calico + Cats Effect, and registers the contributor in the global contributor list.
Changes:
- Added
arnavsharma990contributor component implementing an interactive Tic-Tac-Toe game usingSignallingRefstate. - Registered
arnavsharma990inallContributorslist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/scala/gsoc/contributors/arnavsharma990.scala |
New contributor UI component with Tic-Tac-Toe game and required policy agreement statement. |
src/main/scala/gsoc/contributors/all.scala |
Adds arnavsharma990 to the allContributors registry list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import calico.html.io.{*, given} | ||
| import calico.syntax.* | ||
|
|
||
| object TicTacToe: |
There was a problem hiding this comment.
TicTacToe is introduced as a public top-level object in the gsoc.contributors package, which unnecessarily expands the package namespace and increases the risk of name collisions with other contributor files. Consider moving the game model/helpers inside the arnavsharma990 contributor block (like other contributors do), or make the helper object explicitly private and uniquely named (e.g., private object ArnavTicTacToe) to keep helper code scoped to this component. (See examples of top-level helpers being private object ... in antoniojimeneznieto.scala:73, tanmay_008.scala:78, yummy_yums.scala:100.)
| object TicTacToe: | |
| private object TicTacToe: |
462e895 to
f0f8490
Compare
f0f8490 to
eb56908
Compare
|
Thank you for agreeing to the Typelevel GSoC AI Policy, in which you committed to never use AI to generate descriptions for PRs. You used Copilot to generate a description of your PR, in violation of our policy. Therefore, I will close your PR at this time. |
arnavsharma990.scalaall.scala