Skip to content

add contributor hehelego with a sequence building app#32

Merged
armanbilge merged 4 commits intotypelevel:mainfrom
hehelego:main
Mar 10, 2026
Merged

add contributor hehelego with a sequence building app#32
armanbilge merged 4 commits intotypelevel:mainfrom
hehelego:main

Conversation

@hehelego
Copy link
Copy Markdown
Contributor

@hehelego hehelego commented Mar 7, 2026

Summary of changes:

  • Add a new contributor component for hehelego.
  • Add a sequence buliding application in the new componenet.
  • The new contributor agrees to follow the CoC and AI Policy.

@hehelego
Copy link
Copy Markdown
Contributor Author

hehelego commented Mar 7, 2026

Had to run sbt scalafmt.
Ready to merge now.

Copy link
Copy Markdown
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I clicked the "check order" button, it is failing. Please check steps 5 and 6 in the README.

@hehelego
Copy link
Copy Markdown
Contributor Author

hehelego commented Mar 9, 2026

When I clicked the "check order" button, it is failing. Please check steps 5 and 6 in the README.

Thanks for the feedback. I cannot make sense of the order validation logic but managed to pass the order check with a manual binary search :P

The last commit should fix the problem.

@hehelego hehelego requested a review from armanbilge March 9, 2026 13:16
@hehelego
Copy link
Copy Markdown
Contributor Author

hehelego commented Mar 9, 2026

Merged the main branch into my branch and resolved the merge conflict.

Copy link
Copy Markdown
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot make sense of the order validation logic

It's random 😆 binary search is the right way to do it, nice job!

@armanbilge armanbilge merged commit 4ceafc2 into typelevel:main Mar 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants