add contributor hehelego with a sequence building app#32
Merged
armanbilge merged 4 commits intotypelevel:mainfrom Mar 10, 2026
Merged
add contributor hehelego with a sequence building app#32armanbilge merged 4 commits intotypelevel:mainfrom
armanbilge merged 4 commits intotypelevel:mainfrom
Conversation
Contributor
Author
|
Had to run |
armanbilge
requested changes
Mar 9, 2026
Member
armanbilge
left a comment
There was a problem hiding this comment.
When I clicked the "check order" button, it is failing. Please check steps 5 and 6 in the README.
Contributor
Author
Thanks for the feedback. I cannot make sense of the order validation logic but managed to pass the order check with a manual binary search :P The last commit should fix the problem. |
Contributor
Author
|
Merged the main branch into my branch and resolved the merge conflict. |
armanbilge
approved these changes
Mar 10, 2026
Member
armanbilge
left a comment
There was a problem hiding this comment.
I cannot make sense of the order validation logic
It's random 😆 binary search is the right way to do it, nice job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
hehelego.