Eta573

[rajcspsg]

@rahulmutt - I've updated the changes for the issue eta 573. Looks like I've created PR against wrong branch. could you please let me know the correct branch. I will create different PR against correct branch.

[CLAassistant]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Rajkumar Natarajan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[rahulmutt]

Hi @rajcspsg, it looks like you need to update your fork's master to the current master for eta and then make you changes on top of a new branch that starts from the updated master in yor fork.

[rajcspsg]

Thanks @rahulmutt. I've updated the PR.
Mostly I've updated the class package and refactored the usages of those classes in this PR. Only in this class https://github.com/typelead/eta/pull/721/files#diff-2f5c68896b14fe36169b53a471cd71b9 I've added getter/setters, since the default access modifiers for those fields doesn't let me to use the same in different package.

[rahulmutt]

Looks like the build failed: https://circleci.com/gh/typelead/eta/1467?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Can you make sure you run ./cleaninstall.sh with your changes and made it pass locally?

[rajcspsg]

@rahulmutt I've tried | hasStdLayout = T.pack ((++) (show fvs) "runtime/thunk/") and | hasStdLayout = T.pack ((++) "runtime/thunk/" (show fvs) ) still I get Caused by: java.lang.ClassNotFoundException: eta.UpdatableThunk5runtime.thunk.error. Any idea?

[rahulmutt]

Why are you trying to add runtime/thunk/ instead of removing it above? Have you changed the names of all the eta/runtime/thunk/*Thunk* classes to eta/*Thunk*?

[rajcspsg]

@rahulmutt The classes Thunk, UpdatableThunk are only moved to package eta.
The remaining Thunk classes are present in package package eta/runtime/thunk.
when I make package as eta , I get getting CNFE for java.lang.NoClassDefFoundError: eta/UpdatableThunk2.
when I make package as eta/runtime/thunk/ , I get getting CNFE for java.lang.NoClassDefFoundError: eta/runtime/thunk/UpdatableThunk.
so, I'm trying to find way to include both eta/UpdatableThunk and eta/runtime/thunk/**.

[rahulmutt]

I think it will be easier if you shifted all the eta/runtime/thunk/** classes to eta/*. That way you won't have to add special cases in the logic.

[rajcspsg]

@rahulmutt - We could do that but I feel that makes rts code bit unorganized correct?

[rahulmutt]

I think it's fine to move up the specialized thunks and functions up to the eta package. They will be exposed in the public runtime API for those who need it.