Skip to content

Fix invalid automation.yml and update dependencies #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .factory/automation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,4 +143,4 @@ release:
command: |
export DEPLOY_CRATE_TOKEN=$REPO_CRATES_TOKEN
bazel run --define version=$(cat VERSION) //grpc/rust:deploy_crate -- release
dependencies: [build, build-dependency]
dependencies: [deploy-github]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[deploy-github] is the correct dependency list. This was not previously caught in CI because of:

4 changes: 2 additions & 2 deletions dependencies/vaticle/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
def vaticle_dependencies():
git_repository(
name = "vaticle_dependencies",
remote = "https://github.com/alexjpwalker/dependencies",
commit = "1bf0ec950a59ad170c826f9fe163701c2e0b2233", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
remote = "https://github.com/vaticle/dependencies",
commit = "49de5861769ebb4b4b87438324e8a5922bf75dbe", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_dependencies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

)