Skip to content

Commit

Permalink
Possible fix for #56
Browse files Browse the repository at this point in the history
  • Loading branch information
tylercd100 committed Jul 3, 2018
1 parent 9b83ff4 commit 314f608
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 5 deletions.
2 changes: 1 addition & 1 deletion phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
convertNoticesToExceptions="true"
convertWarningsToExceptions="true"
processIsolation="false"
stopOnFailure="false">
stopOnFailure="true">
<php>
<env name="APP_KEY" value="8bff3a6e61f548c0ecd9ad52e3cf3738"/>
</php>
Expand Down
7 changes: 3 additions & 4 deletions src/Components/Component.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ abstract class Component {
protected $dontHandle = [];

/**
* This array is overwritten in each component
*
* @var array
*/
private $absolutelyDontHandle = [
\Tylercd100\LERN\Exceptions\RecorderFailedException::class,
\Tylercd100\LERN\Exceptions\NotifierFailedException::class,
];
private $absolutelyDontHandle = [];

/**
* Determine if the exception is in the "do not handle" list.
Expand Down
7 changes: 7 additions & 0 deletions src/Components/Notifier.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ class Notifier extends Component
protected $subjectCb;
protected $contextCb;

/**
* @var array
*/
private $absolutelyDontHandle = [
\Tylercd100\LERN\Exceptions\NotifierFailedException::class,
];

/**
* You can provide a Monolog Logger instance to use in the constructor
* @param Logger|null $log Logger instance to use
Expand Down
7 changes: 7 additions & 0 deletions src/Components/Recorder.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ class Recorder extends Component {
*/
protected $config = [];

/**
* @var array
*/
private $absolutelyDontHandle = [
\Tylercd100\LERN\Exceptions\RecorderFailedException::class,
];

/**
* The constructor
*/
Expand Down

0 comments on commit 314f608

Please sign in to comment.