Skip to content

make getting expiration better and fix new rustdoc tool lint - #40

Merged
bors[bot] merged 2 commits into
masterfrom
fixes
Mar 5, 2021
Merged

make getting expiration better and fix new rustdoc tool lint#40
bors[bot] merged 2 commits into
masterfrom
fixes

Conversation

@Emilgardis

@Emilgardis Emilgardis commented Mar 5, 2021

Copy link
Copy Markdown
Member

No description provided.

Emilgardis
Emilgardis commented Mar 5, 2021
View reviewed changes

@Emilgardis Emilgardis left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors

bors Bot commented Mar 5, 2021

Copy link
Copy Markdown
Contributor

Build failed:

@Emilgardis
Emilgardis force-pushed the fixes branch 2 times, most recently from 942569b to 1ebc90e Compare March 5, 2021 22:32
@Emilgardis

Emilgardis commented Mar 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

rust-lang/rust#80527

#[allow(unknown_lints)] does not work for this change, need to use renamed_and_removed_lints instead. Allows will be weird for some time I think.

Edit:
Seems this change causes even more trouble. For now I'll make the rustdoc::broken_intra_doc_links nightly only

@Emilgardis
fix lint error
fc8de9f 
also bumps msrv
@Emilgardis Emilgardis changed the title make getting expiration better make getting expiration better and fix new rustdoc tool lint Mar 5, 2021
@Emilgardis

Emilgardis commented Mar 5, 2021

Copy link
Copy Markdown
Member Author

bors r+

@bors

bors Bot commented Mar 5, 2021

Copy link
Copy Markdown
Contributor

Build succeeded:

@bors
bors Bot merged commit 0907253 into master Mar 5, 2021
@bors
bors Bot deleted the fixes branch March 5, 2021 22:54
@Emilgardis Emilgardis mentioned this pull request Mar 5, 2021
Merged
Emilgardis
Emilgardis commented Mar 5, 2021
View reviewed changes

@Emilgardis Emilgardis left a comment •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing expires_in in https://github.com/Emilgardis/twitch_oauth2/blob/0907253396f5aaaaf9db4788fd4170f7ba236c73/src/tokens/app_access_token.rs#L71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Emilgardis